From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: How to deal with consequences of update to attr Date: Mon, 08 Feb 2021 13:42:04 +0000 Message-ID: <6FD6DEF5-4211-4B60-8CCF-FD15413209AF@ipfire.org> In-Reply-To: <71fa15a3-603e-7f95-517e-5cc2ea33046f@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7160926475454545132==" List-Id: --===============7160926475454545132== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, > On 8 Feb 2021, at 13:41, Adolf Belka (ipfire-dev) wrote: >=20 > Hi Michael, >=20 > On 08/02/2021 14:21, Michael Tremer wrote: >> Hello, >> I am trying to keep up with all your emails. So forgive me if it takes a l= ittle while :) > This one was only sent this morning so you replied quickly to it. I underst= and if a reply takes longer so no problems. I struggle with replying in order and usually work my way down from top to bo= ttom :) >>> On 8 Feb 2021, at 09:01, Adolf Belka (ipfire-dev) wrote: >>>=20 >>> Hi all, >>>=20 >>> I found that attr was from 2013 but that there was a newer update from 20= 18, so I ran a build of the update which worked fine. >>>=20 >>> However python-xattr failed to build because xattr.h was not provided by = the new version of attr. I realised that python-xattr-0.5.0 was from 2007 so = really needed updating also. >> Interesting that so much has changed in this package. >> I would say that we should drop python-xattr. It was needed for pakfire 3 = which no longer depends on this python module. On top of this, this is a Pyth= on 2 module and since Python 2 is EOL we should start to remove them all one = by one. Software needs to be ported to Python 3 and we will need to remove Py= thon 2 entirely at least from the installed system - it might be needed in th= e build environment. >>> Ran the build for python-xattr-0.9.7 from 2019. However it required pytho= n-cffi. So I added that. python-cffi also requires python-setuptools, which i= s available as an addon so I just had to adjust the order of the build to inc= lude that. Then had to add python-pycparser as that is also required by pytho= n-cffi. >>>=20 >>> After all of the above the package completed building without any errors. >>>=20 >>> My question is about the additional required python packages cffi (C Fore= ign Function Interface) and pycparser (Complete parser for C acting as a fron= t end for C Compilers or analysis tools). >>>=20 >>> It doesn't seem like they should need to be added as addons just so that = python-xattr can be built. It would make more sense to me to add them only fo= r the building portion. Presumably I place the required programs into the bui= ldbase section of make.sh but how do I ensure that they are only used in the = build and not also included in the final IPFire. >>>=20 >>> I see that meson is in the buildbase section and is not in the final IPFi= re but gzip is also in the buildbase section but does end up in the final IPF= ire but I can't see what I need to specify to make sure the additional python= packages follow the meson approach and not the gzip approach. I suspect it w= ill turnout to be obvious but I have not been able to figure it out. >> Yes, loads of tools will not be shipped with the system because they are n= ot needed there and we try to keep IPFire as small as possible - within reaso= n. So they could have been a package just like meson or binutils, but since n= obody is using the python-xattr module any more, it would be better to remove= it. > Okay, that is a simple solution. I will create a new patch with attr and th= e removal of python-xattr. >=20 > Regards, > Adolf. >> -Michael >>>=20 >>> Help required please on how to go about this. >>>=20 >>>=20 >>> Thanks and regards, >>>=20 >>> Adolf. >>>=20 >>> --=20 >>> Sent from my desktop >>>=20 >=20 > --=20 > Sent from my laptop --===============7160926475454545132==--