How to deal with consequences of update to attr

How to deal with consequences of update to attr

[Adolf Belka (ipfire-dev)]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

Hi all,

I found that attr was from 2013 but that there was a newer update from 2018, so I ran a build of the update which worked fine.

However python-xattr failed to build because xattr.h was not provided by the new version of attr. I realised that python-xattr-0.5.0 was from 2007 so really needed updating also.

Ran the build for python-xattr-0.9.7 from 2019. However it required python-cffi. So I added that. python-cffi also requires python-setuptools, which is available as an addon so I just had to adjust the order of the build to include that. Then had to add python-pycparser as that is also required by python-cffi.

After all of the above the package completed building without any errors.

My question is about the additional required python packages cffi (C Foreign Function Interface) and pycparser (Complete parser for C acting as a front end for C Compilers or analysis tools).

It doesn't seem like they should need to be added as addons just so that python-xattr can be built. It would make more sense to me to add them only for the building portion. Presumably I place the required programs into the buildbase section of make.sh but how do I ensure that they are only used in the build and not also included in the final IPFire.

I see that meson is in the buildbase section and is not in the final IPFire but gzip is also in the buildbase section but does end up in the final IPFire but I can't see what I need to specify to make sure the additional python packages follow the meson approach and not the gzip approach. I suspect it will turnout to be obvious but I have not been able to figure it out.

Help required please on how to go about this.


Thanks and regards,

Adolf.

-- 
Sent from my desktop

Re: How to deal with consequences of update to attr

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2790 bytes --]

Hello,

I am trying to keep up with all your emails. So forgive me if it takes a little while :)

> On 8 Feb 2021, at 09:01, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
> 
> Hi all,
> 
> I found that attr was from 2013 but that there was a newer update from 2018, so I ran a build of the update which worked fine.
> 
> However python-xattr failed to build because xattr.h was not provided by the new version of attr. I realised that python-xattr-0.5.0 was from 2007 so really needed updating also.

Interesting that so much has changed in this package.

I would say that we should drop python-xattr. It was needed for pakfire 3 which no longer depends on this python module. On top of this, this is a Python 2 module and since Python 2 is EOL we should start to remove them all one by one. Software needs to be ported to Python 3 and we will need to remove Python 2 entirely at least from the installed system - it might be needed in the build environment.

> Ran the build for python-xattr-0.9.7 from 2019. However it required python-cffi. So I added that. python-cffi also requires python-setuptools, which is available as an addon so I just had to adjust the order of the build to include that. Then had to add python-pycparser as that is also required by python-cffi.
> 
> After all of the above the package completed building without any errors.
> 
> My question is about the additional required python packages cffi (C Foreign Function Interface) and pycparser (Complete parser for C acting as a front end for C Compilers or analysis tools).
> 
> It doesn't seem like they should need to be added as addons just so that python-xattr can be built. It would make more sense to me to add them only for the building portion. Presumably I place the required programs into the buildbase section of make.sh but how do I ensure that they are only used in the build and not also included in the final IPFire.
> 
> I see that meson is in the buildbase section and is not in the final IPFire but gzip is also in the buildbase section but does end up in the final IPFire but I can't see what I need to specify to make sure the additional python packages follow the meson approach and not the gzip approach. I suspect it will turnout to be obvious but I have not been able to figure it out.

Yes, loads of tools will not be shipped with the system because they are not needed there and we try to keep IPFire as small as possible - within reason. So they could have been a package just like meson or binutils, but since nobody is using the python-xattr module any more, it would be better to remove it.

-Michael

> 
> Help required please on how to go about this.
> 
> 
> Thanks and regards,
> 
> Adolf.
> 
> -- 
> Sent from my desktop
> 

Re: How to deal with consequences of update to attr

[Adolf Belka (ipfire-dev)]

[-- Attachment #1: Type: text/plain, Size: 3168 bytes --]

Hi Michael,

On 08/02/2021 14:21, Michael Tremer wrote:
> Hello,
> 
> I am trying to keep up with all your emails. So forgive me if it takes a little while :)
This one was only sent this morning so you replied quickly to it. I 
understand if a reply takes longer so no problems.
> 
>> On 8 Feb 2021, at 09:01, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi all,
>>
>> I found that attr was from 2013 but that there was a newer update from 2018, so I ran a build of the update which worked fine.
>>
>> However python-xattr failed to build because xattr.h was not provided by the new version of attr. I realised that python-xattr-0.5.0 was from 2007 so really needed updating also.
> 
> Interesting that so much has changed in this package.
> 
> I would say that we should drop python-xattr. It was needed for pakfire 3 which no longer depends on this python module. On top of this, this is a Python 2 module and since Python 2 is EOL we should start to remove them all one by one. Software needs to be ported to Python 3 and we will need to remove Python 2 entirely at least from the installed system - it might be needed in the build environment.
> 
>> Ran the build for python-xattr-0.9.7 from 2019. However it required python-cffi. So I added that. python-cffi also requires python-setuptools, which is available as an addon so I just had to adjust the order of the build to include that. Then had to add python-pycparser as that is also required by python-cffi.
>>
>> After all of the above the package completed building without any errors.
>>
>> My question is about the additional required python packages cffi (C Foreign Function Interface) and pycparser (Complete parser for C acting as a front end for C Compilers or analysis tools).
>>
>> It doesn't seem like they should need to be added as addons just so that python-xattr can be built. It would make more sense to me to add them only for the building portion. Presumably I place the required programs into the buildbase section of make.sh but how do I ensure that they are only used in the build and not also included in the final IPFire.
>>
>> I see that meson is in the buildbase section and is not in the final IPFire but gzip is also in the buildbase section but does end up in the final IPFire but I can't see what I need to specify to make sure the additional python packages follow the meson approach and not the gzip approach. I suspect it will turnout to be obvious but I have not been able to figure it out.
> 
> Yes, loads of tools will not be shipped with the system because they are not needed there and we try to keep IPFire as small as possible - within reason. So they could have been a package just like meson or binutils, but since nobody is using the python-xattr module any more, it would be better to remove it.
Okay, that is a simple solution. I will create a new patch with attr and 
the removal of python-xattr.

Regards,
Adolf.
> 
> -Michael
> 
>>
>> Help required please on how to go about this.
>>
>>
>> Thanks and regards,
>>
>> Adolf.
>>
>> -- 
>> Sent from my desktop
>>
> 

-- 
Sent from my laptop

Re: How to deal with consequences of update to attr

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3386 bytes --]

Hi,

> On 8 Feb 2021, at 13:41, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 08/02/2021 14:21, Michael Tremer wrote:
>> Hello,
>> I am trying to keep up with all your emails. So forgive me if it takes a little while :)
> This one was only sent this morning so you replied quickly to it. I understand if a reply takes longer so no problems.

I struggle with replying in order and usually work my way down from top to bottom :)

>>> On 8 Feb 2021, at 09:01, Adolf Belka (ipfire-dev) <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi all,
>>> 
>>> I found that attr was from 2013 but that there was a newer update from 2018, so I ran a build of the update which worked fine.
>>> 
>>> However python-xattr failed to build because xattr.h was not provided by the new version of attr. I realised that python-xattr-0.5.0 was from 2007 so really needed updating also.
>> Interesting that so much has changed in this package.
>> I would say that we should drop python-xattr. It was needed for pakfire 3 which no longer depends on this python module. On top of this, this is a Python 2 module and since Python 2 is EOL we should start to remove them all one by one. Software needs to be ported to Python 3 and we will need to remove Python 2 entirely at least from the installed system - it might be needed in the build environment.
>>> Ran the build for python-xattr-0.9.7 from 2019. However it required python-cffi. So I added that. python-cffi also requires python-setuptools, which is available as an addon so I just had to adjust the order of the build to include that. Then had to add python-pycparser as that is also required by python-cffi.
>>> 
>>> After all of the above the package completed building without any errors.
>>> 
>>> My question is about the additional required python packages cffi (C Foreign Function Interface) and pycparser (Complete parser for C acting as a front end for C Compilers or analysis tools).
>>> 
>>> It doesn't seem like they should need to be added as addons just so that python-xattr can be built. It would make more sense to me to add them only for the building portion. Presumably I place the required programs into the buildbase section of make.sh but how do I ensure that they are only used in the build and not also included in the final IPFire.
>>> 
>>> I see that meson is in the buildbase section and is not in the final IPFire but gzip is also in the buildbase section but does end up in the final IPFire but I can't see what I need to specify to make sure the additional python packages follow the meson approach and not the gzip approach. I suspect it will turnout to be obvious but I have not been able to figure it out.
>> Yes, loads of tools will not be shipped with the system because they are not needed there and we try to keep IPFire as small as possible - within reason. So they could have been a package just like meson or binutils, but since nobody is using the python-xattr module any more, it would be better to remove it.
> Okay, that is a simple solution. I will create a new patch with attr and the removal of python-xattr.
> 
> Regards,
> Adolf.
>> -Michael
>>> 
>>> Help required please on how to go about this.
>>> 
>>> 
>>> Thanks and regards,
>>> 
>>> Adolf.
>>> 
>>> -- 
>>> Sent from my desktop
>>> 
> 
> -- 
> Sent from my laptop