Possible bug in 'backup.cgi' after these commits!?

Possible bug in 'backup.cgi' after these commits!?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Hi,

I don't know if this will become relevant, but...

I tested these two commits:

https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=7f6257e0a475681ff243ead159cafee2e03f6265

and

https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=614764e58af6dd710658fd072ed9b3a1b51f805a

Keen to experiment (as I am), I installed the new 'backup.cgi' on my
running Core 123.

After this, GUI looked normal. I could still make backups. But I
couldn't delete the addon backup files. After clicking on the 'delete'
icon, GUI disappered, came back partially (as it seemed, only the
header) and after hitting 'reload', the addon backup files (*.ipf) were
still there. IPF-file rights seemed to be ok, but I couldn't delete them
through the GUI.

Can anyone confirm? Or is it my mistake?

Best,
Matthias

Re: Possible bug in 'backup.cgi' after these commits!?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

Possible that I broke something. Please test further and open a bug
report if necessary.

Best,
-Michael

On Sat, 2018-09-15 at 13:00 +0200, Matthias Fischer wrote:
> Hi,
> 
> I don't know if this will become relevant, but...
> 
> I tested these two commits:
> 
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=7f6257e0a475681ff243ead159cafee2e03f6265
> 
> and
> 
> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=614764e58af6dd710658fd072ed9b3a1b51f805a
> 
> Keen to experiment (as I am), I installed the new 'backup.cgi' on my
> running Core 123.
> 
> After this, GUI looked normal. I could still make backups. But I
> couldn't delete the addon backup files. After clicking on the 'delete'
> icon, GUI disappered, came back partially (as it seemed, only the
> header) and after hitting 'reload', the addon backup files (*.ipf) were
> still there. IPF-file rights seemed to be ok, but I couldn't delete them
> through the GUI.
> 
> Can anyone confirm? Or is it my mistake?
> 
> Best,
> Matthias

Re: Possible bug in 'backup.cgi' after these commits!?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Hi,

I tested again, got the same result and opened a bug report:
https://bugzilla.ipfire.org/show_bug.cgi?id=11863

Best,
Matthias

On 15.09.2018 13:10, Michael Tremer wrote:
> Possible that I broke something. Please test further and open a bug
> report if necessary.
> 
> Best,
> -Michael
> 
> On Sat, 2018-09-15 at 13:00 +0200, Matthias Fischer wrote:
>> Hi,
>> 
>> I don't know if this will become relevant, but...
>> 
>> I tested these two commits:
>> 
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=7f6257e0a475681ff243ead159cafee2e03f6265
>> 
>> and
>> 
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=614764e58af6dd710658fd072ed9b3a1b51f805a
>> 
>> Keen to experiment (as I am), I installed the new 'backup.cgi' on my
>> running Core 123.
>> 
>> After this, GUI looked normal. I could still make backups. But I
>> couldn't delete the addon backup files. After clicking on the 'delete'
>> icon, GUI disappered, came back partially (as it seemed, only the
>> header) and after hitting 'reload', the addon backup files (*.ipf) were
>> still there. IPF-file rights seemed to be ok, but I couldn't delete them
>> through the GUI.
>> 
>> Can anyone confirm? Or is it my mistake?
>> 
>> Best,
>> Matthias
> 
>