public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: "IPFire: Development-List" <development@lists.ipfire.org>
Subject: duplicate get_aliases subroutines found
Date: Sat, 8 Mar 2025 14:51:29 +0100	[thread overview]
Message-ID: <6e0d1e9a-3b62-4690-a6ba-a04628aaf9e2@ipfire.org> (raw)

Hi All,

I was searching through the bugs list and found bug11393 about 
refactoring the network functions.

Based on that I was having a look at what network functions were still 
in general-functions.pl and on investigating I found that there is a sub 
get_aliases in general-functions.pl and also in ids-functions.pl

They are clearly doing the same thing but with some differences. I am 
not able to tell which is the better version to keep or if a version 
combining aspects of both are needed.

If it is just a case of using one of them and putting it into the 
network-functions.pl library and then updating all the references, then 
I could do that without problems. If something needs to be changed then 
I would need some guidance.

Of course the above also depends on get_aliases being considered to be a 
network function, which was my interpretation.

I found quite a lot that are still in general-functions.pl

Regards,

Adolf.

-- 
Sent from my laptop



             reply	other threads:[~2025-03-08 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08 13:51 Adolf Belka [this message]
2025-03-10 10:22 ` Michael Tremer
2025-03-10 11:12   ` Adolf Belka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e0d1e9a-3b62-4690-a6ba-a04628aaf9e2@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox