From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Z94MG5Rsmz34b2 for ; Sat, 8 Mar 2025 13:51:38 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Z94MC0KFNz346J for ; Sat, 8 Mar 2025 13:51:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4Z94MB1jyhz1Vs for ; Sat, 8 Mar 2025 13:51:34 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1741441894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ggLnhpl9OO/ZD3TUQtm+7KucYhtMtOKQNShNEJVxHMs=; b=gA4m90GixBge8ETvFbgNx+Wf1Hl0iotQ31+eWr/HkuoVvNOu4RZTAi1VRoZg2PdxZ47Ug6 qxoCJQXyz4/QwOCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1741441894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ggLnhpl9OO/ZD3TUQtm+7KucYhtMtOKQNShNEJVxHMs=; b=uT5rl8S+Z2/ily5o41k14yCjVEVyXZDfu/kIR4lJnb15jcxycuDYIeLPZ2ty20CTyuqy7Q DalQHRC+2R2ivIFLQwFJQ4Da9oZGFSPB8eMRxRRxxG9YfwaVc+HoLC0yPmmD9jPF0qCAaS 5tjfPt+2faTiABvq68iCl2wD5SwGocNyMJlws2E74bR+5bjsPELwP6A7a+n0SE+pMrnGiG OSUQnbb7yfKBpmrL7eV8b4fnS7jdF1JwqwtmDIMcudQ+2A52IzG4QyVj99Oca/+SFr6v9c 9V9fSjGbwHOjDQgPvxr1FW5p82oMRr98eRU6w32yBkxRvfAw+b9nNVo2UnOzrw== Message-ID: <6e0d1e9a-3b62-4690-a6ba-a04628aaf9e2@ipfire.org> Date: Sat, 8 Mar 2025 14:51:29 +0100 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Language: en-GB To: "IPFire: Development-List" From: Adolf Belka Subject: duplicate get_aliases subroutines found Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi All, I was searching through the bugs list and found bug11393 about refactoring the network functions. Based on that I was having a look at what network functions were still in general-functions.pl and on investigating I found that there is a sub get_aliases in general-functions.pl and also in ids-functions.pl They are clearly doing the same thing but with some differences. I am not able to tell which is the better version to keep or if a version combining aspects of both are needed. If it is just a case of using one of them and putting it into the network-functions.pl library and then updating all the references, then I could do that without problems. If something needs to be changed then I would need some guidance. Of course the above also depends on get_aliases being considered to be a network function, which was my interpretation. I found quite a lot that are still in general-functions.pl Regards, Adolf. -- Sent from my laptop