From mboxrd@z Thu Jan  1 00:00:00 1970
From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] tor: Fix tor permissions if presant via update.sh
Date: Mon, 10 Jun 2019 21:10:01 +0200
Message-ID: <6e5bce5c5e7b0141ea562cfc2b5dc5bb422fffb9.camel@ipfire.org>
In-Reply-To: <16323d1c-c9d0-4675-136c-cdd075e3a0e0@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3902791860737000670=="
List-Id: <development.lists.ipfire.org>

--===============3902791860737000670==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Michael & Peter,

On Mo, 2019-06-10 at 18:12 +0000, Peter Müller wrote:
> Hello Michael,
> 
> as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=12088#c11
>  ,
> the "install.sh" script of the Tor addon contains all required steps.
> 
> Since "update.sh" calls "install.sh" at the end of the file,
> everything
> should be fine after an update as well - which is not. However, due
> to
> this, I do not think putting it into "update.sh" makes sense either.
Thought a little in the same way since there is also an update for tor
whereby tor´s update.sh (includes install.sh then) should be executed.
To stay save i used the core update.sh for this...

Best,

Erik

> 
> Thanks, and best regards,
> Peter Müller
> 
> Michael Tremer:
> > Hi,
> > 
> > Thanks for sending in that patch.
> > 
> > But I think instead of doing this in the Core Update, this change
> > should be applied in the tor update scripts.
> > 
> > -Michael
> > 
> > > On 10 Jun 2019, at 12:36, Erik Kapfer <ummeegge(a)ipfire.org>
> > > wrote:
> > > 
> > > Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> > > ---
> > > config/rootfiles/core/133/update.sh | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/config/rootfiles/core/133/update.sh
> > > b/config/rootfiles/core/133/update.sh
> > > index a05ad0741..3ecb5651b 100644
> > > --- a/config/rootfiles/core/133/update.sh
> > > +++ b/config/rootfiles/core/133/update.sh
> > > @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-
> > > bin/vpnmain.cgi
> > > /etc/init.d/squid start
> > > /etc/init.d/collectd restart
> > > 
> > > +# Set new permissions for tor
> > > +if [ -d "/var/lib/tor" ]; then
> > > +    chown -R tor:tor /var/lib/tor
> > > +fi
> > > +
> > > # Finish
> > > /etc/init.d/fireinfo start
> > > sendprofile
> > > -- 
> > > 2.12.2
> > > 
> 
> 


--===============3902791860737000670==--