public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] miniupnpd: Delete files that would have become orphaned after deletion of miniupnpd add-on as well
Date: Tue, 18 May 2021 21:58:27 +0200	[thread overview]
Message-ID: <701e4761-950d-71d1-d423-ecd8908decd2@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 3189 bytes --]

This patch requires
https://patchwork.ipfire.org/project/ipfire/list/?series=2059 to be
applied in the first place.

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 config/miniupnpd/miniupnpd.conf               | 50 -------------------
 .../networking/red.down/10-miniupnpd          |  6 ---
 .../networking/red.up/10-miniupnpd            |  6 ---
 3 files changed, 62 deletions(-)
 delete mode 100644 config/miniupnpd/miniupnpd.conf
 delete mode 100644 src/initscripts/networking/red.down/10-miniupnpd
 delete mode 100644 src/initscripts/networking/red.up/10-miniupnpd

diff --git a/config/miniupnpd/miniupnpd.conf b/config/miniupnpd/miniupnpd.conf
deleted file mode 100644
index 582758192..000000000
--- a/config/miniupnpd/miniupnpd.conf
+++ /dev/null
@@ -1,50 +0,0 @@
-
-# LAN network interfaces IPs / networks
-# there can be multiple listening ips for SSDP traffic.
-# should be under the form nnn.nnn.nnn.nnn/nn
-listening_ip=green0
-#listening_ip=green1
-
-# HTTP is available on all interfaces
-# port for HTTP (descriptions and SOAP) traffic. set 0 for autoselect.
-port=0
-
-# chain names for netfilter (not used for pf or ipf).
-upnp_forward_chain=UPNPFW
-upnp_nat_chain=UPNPFW
-
-# bitrates reported by daemon in bits per second
-bitrate_up=1000000
-bitrate_down=10000000
-
-# "secure" mode : when enabled, UPnP client are allowed to add mappings only
-# to their IP.
-secure_mode=yes
-
-# report system uptime instead of daemon uptime
-system_uptime=yes
-
-# notify interval in seconds. default is 30 seconds.
-notify_interval=60
-
-# unused rules cleaning.
-# never remove any rule before this threshold for the number
-# of redirections is exceeded. default to 20
-#clean_ruleset_threshold=10
-# clean process work interval in seconds. default to 0 (disabled).
-# a 600 seconds (10 minutes) interval makes sense
-clean_ruleset_interval=600
-
-# serial and model number the daemon will report to clients
-# in its XML description
-serial=12345678
-model_number=1
-
-# UPnP permission rules
-# (allow|deny) (external port range) ip/mask (internal port range)
-# A port range is <min port>-<max port> or <port> if there is only
-# one port in the range.
-# ip/mask format must be nn.nn.nn.nn/nn
-# it is advised to only allow redirection of port above 1024
-# and to finish the rule set with "deny 0-65535 0.0.0.0/0 0-65535"
-allow 0-65535 0.0.0.0/0 0-65535
diff --git a/src/initscripts/networking/red.down/10-miniupnpd b/src/initscripts/networking/red.down/10-miniupnpd
deleted file mode 100644
index eaf2239e9..000000000
--- a/src/initscripts/networking/red.down/10-miniupnpd
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/bash
-
-[ -x /etc/init.d/miniupnpd ] && \
-	/etc/init.d/miniupnpd stop &>/dev/null
-
-exit 0
diff --git a/src/initscripts/networking/red.up/10-miniupnpd b/src/initscripts/networking/red.up/10-miniupnpd
deleted file mode 100644
index 54431331b..000000000
--- a/src/initscripts/networking/red.up/10-miniupnpd
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/bash
-
-[ -x /etc/init.d/miniupnpd ] && \
-	/etc/init.d/miniupnpd start &>/dev/null
-
-exit 0
-- 
2.26.2

             reply	other threads:[~2021-05-18 19:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 19:58 Peter Müller [this message]
2021-05-20  9:37 ` Michael Tremer
2021-05-20 21:27   ` Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=701e4761-950d-71d1-d423-ecd8908decd2@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox