From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4ZLQl85fRbz333G for ; Sun, 23 Mar 2025 19:11:16 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4ZLQl51w66z331L for ; Sun, 23 Mar 2025 19:11:13 +0000 (UTC) Received: from resqmta-c2p-570110.sys.comcast.net (resqmta-c2p-570110.sys.comcast.net [IPv6:2001:558:fd00:56::b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4ZLQl34z1lzWD for ; Sun, 23 Mar 2025 19:11:11 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b=IAUXhvHH; spf=none (mail01.ipfire.org: domain of stephen@firemypi.org has no SPF policy when checking 2001:558:fd00:56::b) smtp.mailfrom=stephen@firemypi.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1742757072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RyYx0L8nbjBoI1SKnEliVNPHEASer1LTYuRYIxdYVhU=; b=eG8RPkV3llegqW+ihxV32Vl/G6k6teUe1YjK/KvvBA6UjveelclnffWTKDpZSt9t3FBgan GPmMfbAZp8yukSd5TTtPt3r7A80+5YCj3+EnXYhkeqDmVTuzp952+xnuO0CvLU0tGoNRJY +oNmL9+8p3qVnJ9qO+5Xzti4Z1eJBNh4bAsqFuwaH3ZOQPiHmUIjhMcsUSTkZfwg6nyOdW bFo88MRk3qYslX66+EazjnUOXD65v6bD/H7sg8tOBrgyEAvLVxyaaUUzgO2Za1j9lx6faO VUzGt9kq7ReqNp6KP09pArf4+0/87an6Bme6foVwG3Wo92MU2Zi8Q23tYr7QJg== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b=IAUXhvHH; spf=none (mail01.ipfire.org: domain of stephen@firemypi.org has no SPF policy when checking 2001:558:fd00:56::b) smtp.mailfrom=stephen@firemypi.org; dmarc=none ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1742757072; a=rsa-sha256; cv=none; b=ioasKBhHyURkNnyW+jVa0OPHJ7QPpkR9LGPpPBUZXbkmik818dADTLfGYw93GxWA+T7RZh 7kR42P+FhFsONc/wHdsX4zq9tCbbLBDvDOa/wTPvcTVl036anTu4uAEP4KnqpiHKgBkRRU cRCO0cbdVffFKaOw2FTvgCStW6X6Kb6EDalThD/5ZxPqirp3T6Q2NCkSwmXOH0Gsgt/naD 7WTc3a5F+xtMtUs5HZas6M+LrjXzEfp25iVXcjmfA+X6hV/Nk2+4nvG9ZIhlhlu5buslcV bG4GIqHlplnwPUl0yJnnUvVaYHtakWO/0El0lMwmlI+vOB7Lnx0JRC6i2zo3xQ== Received: from resomta-c2p-555442.sys.comcast.net ([96.102.18.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits) (Client did not present a certificate) by resqmta-c2p-570110.sys.comcast.net with ESMTPS id wPqptQBsOH9bRwQiwtvQKT; Sun, 23 Mar 2025 19:11:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1742757066; bh=RyYx0L8nbjBoI1SKnEliVNPHEASer1LTYuRYIxdYVhU=; h=Received:Received:Message-ID:Date:MIME-Version:Subject:To:From: Content-Type:Xfinity-Spam-Result; b=IAUXhvHHaPN46Rt5rLpC3BM9kvVPAyVACoF2SQ9886Qew18LQ8+D/43mPWdDH5rzZ J8ZC6uIZ5e5nt8RxaSVezwW6TEmEolMAclZJAuwANrq4zI1aW7GgzGGpWAncNzzp42 5qZz0/G+OYJf1Mp+1Kd6megmjGgCApeGngbJLmgx1C1PjRjfI6Watn2hPAEgefsa16 BSaCEkn6u+jCtEmPP0ea8w87b2ySXykxvwD28VsB872gBLiO7d++dHIM/dINz/Afbu XxbxqFGYW7l/VDkhV+tondEeUwae9iTlJ7bVFWqNiT2GJgsy6DWKRzNnt13Op8HOoL y2bVcn/FYaP7w== Received: from [192.168.3.30] ([75.70.122.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits) (Client did not present a certificate) by resomta-c2p-555442.sys.comcast.net with ESMTPSA id wQittGVSi7UkhwQiutrS1b; Sun, 23 Mar 2025 19:11:05 +0000 Message-ID: <725b3ce8-4d36-448d-bc43-b6ef55f81fc0@firemypi.org> Date: Sun, 23 Mar 2025 13:11:03 -0600 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Upcoming pakfire.cgi changes. To: Stephen Cuka Cc: development@lists.ipfire.org References: <40F9151E-D5E6-4186-9BEE-6EE7F002770A@ipfire.org> Content-Language: en-US From: Stephen Cuka In-Reply-To: <40F9151E-D5E6-4186-9BEE-6EE7F002770A@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfK58vsmk2T556YeNtnmSR4ETDuIaLF/5HtGzaBgyiG6VzSuNCkzKqFI+wqFIyUXxWOrnBfJuzwtfKh5arDFM5A8lNIeAj76EIRV+/pz5p1VKAsZHh7ed 5OoXDzuf8O9v8Vx5s9eRzplcNQJQp7TrRddqslifuYXda5pnWWVvUgcRUP3vzj3dBTOsFDQGZ8zcN/B4zw8llA+7f+oxiA3WCgQN3+teEJq3hbGUe61B7Wg8 X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4ZLQl34z1lzWD X-Spamd-Result: default: False [-1.47 / 11.00]; HFILTER_HELO_5(3.00)[resqmta-c2p-570110.sys.comcast.net]; BAYES_HAM(-2.95)[99.79%]; NEURAL_HAM(-1.00)[-0.999]; IP_REPUTATION_HAM(-0.22)[asn: 7922(-0.21), country: US(-0.01), ip: 2001:558:fd00:56::(0.00)]; R_DKIM_ALLOW(-0.20)[comcastmailservice.net:s=20211018a]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DMARC_NA(0.00)[firemypi.org]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[comcastmailservice.net:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1]; RECEIVED_SPAMHAUS_PBL(0.00)[75.70.122.243:received]; DKIM_REPUTATION(0.00)[0]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:7922, ipnet:2001:558::/29, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[96.102.18.241:received] X-Rspamd-Action: no action Hello, On 3/23/25 06:32, Michael Tremer wrote: > Hello, > > Thanks for taking this conversation to here. Let’s also keep it here... > >> On 23 Mar 2025, at 10:48, Stephen Cuka wrote: >> >> Hello, >> >> In reference to the community post: >> >> https://community.ipfire.org/t/core-192-unexpected-upgrade/13760 >> >> I'm going to be submitting a set of patches for changes to pakfire.cgi to fix some problems, do some cleanup, and hopefully improve the overall consistency and appearance of the page. >> >> I wanted to give advance notice of this so that when the patches start coming through you'll be aware of what I'm up to. > *Received* > >> Below is the list of changes that I'm planning to make. >> >> Let me know of questions, comments or concerns. >> >> Regards, >> >> Stephen >> >> ========== >> >> pakfire.cgi patches >> >> >> 1. Add new translation 'pakfire upgrade' to replace 'upgrade'. The 'upgrade' tr is only used in pakfire.cgi and this will move the tr into the pakfire translation block. >> >> 2. Add new translation 'pakfire install' to replace 'install'. The 'install' tr is only used in pakfire.cgi and this will move the tr into the pakfire translation block. >> >> 3. Add translation 'pakfire updates' to en.pl and it.pl. It already exists in the other languages. The 'available updates' tr used in pakfire.cgi will be changed to 'pakfire updates' which will be in the pakfire translation block. >> >> 4. Add translation 'pakfire refresh list'. pakfire.cgi currently uses 'calamaris refresh list'. >> >> 5. Add translations 'pakfire resolvedeps wait', 'pakfire dependencies found' and 'pakfire no dependencies found' to use on install and remove confirmation pages. >> >> 6. Add new translations 'pakfire confirm updates' and 'pakfire updating' for new upgrade confirmation page. >> >> 7. Update pakfire.cgi to use 'pakfire upgrade', 'pakfire install', 'pakfire updates' and 'pakfire refresh list' instead of 'upgrade', 'install', 'available updates' and 'calamaris refresh list'. > The translation issues seem to be a much bigger problem than I thought. > >> 8. Update pakfire.cgi to convert icons to buttons on the main and confirmation pages. Disable Install, Remove and Upgrade buttons if nothing to do. > Hmm, I think this could become a bit confusing, because even though there might not be anything to do right now, a greyed-out button will let the user know where to go whenever there is something to do. > > I am also concerned about potential layout breakages if there are so many changes. The entire web UI is incredibly based on tables and removing a cell somewhere might either mess up the layout or you will need to add a lot of code for simple things. I would rather look at investing this time to replace the web UI as a whole. > >> 9. Update pakfire.cgi to add confirmation page for upgrades. The confirmation page will do a 'pakfire update' to ensure that the local pakfire database is current and then display updates to be made and request confirmation. The box title will be 'pakfire upgrade'. The buttons will still be there but greyed out, so no layout changes.  The Install and Remove buttons will be activated by the onchange