From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] collectd: Restart is required after reconnect
Date: Sun, 14 Jan 2024 16:02:49 +0000 [thread overview]
Message-ID: <73657096-6c02-4b3f-b72d-6b6d9b142a4a@ipfire.org> (raw)
In-Reply-To: <20240112132904.4135555-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 3147 bytes --]
Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
> The "ping" plugin does not re-resolve the gateway IP address after
> pinging it for the first time. For most people this won't be a big
> problem, but if the default gateway changes, the latency graph won't
> work any more.
>
> In order to do re-resolve "gateway", the only way is to restart
> collectd.
>
> Fixes: #13522
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/rootfiles/common/aarch64/initscripts | 1 +
> config/rootfiles/common/riscv64/initscripts | 1 +
> config/rootfiles/common/x86_64/initscripts | 1 +
> src/initscripts/networking/red.up/60-collectd | 6 ++++++
> 4 files changed, 9 insertions(+)
> create mode 100644 src/initscripts/networking/red.up/60-collectd
>
> diff --git a/config/rootfiles/common/aarch64/initscripts b/config/rootfiles/common/aarch64/initscripts
> index f025651c3..a988b4abc 100644
> --- a/config/rootfiles/common/aarch64/initscripts
> +++ b/config/rootfiles/common/aarch64/initscripts
> @@ -62,6 +62,7 @@ etc/rc.d/init.d/networking/red.up/30-ddns
> #etc/rc.d/init.d/networking/red.up/35-guardian
> etc/rc.d/init.d/networking/red.up/50-ipsec
> etc/rc.d/init.d/networking/red.up/50-ovpn
> +etc/rc.d/init.d/networking/red.up/60-collectd
> etc/rc.d/init.d/networking/red.up/98-leds
> etc/rc.d/init.d/networking/red.up/99-beep
> etc/rc.d/init.d/networking/red.up/99-fireinfo
> diff --git a/config/rootfiles/common/riscv64/initscripts b/config/rootfiles/common/riscv64/initscripts
> index 8a4f046d3..a5e1596fb 100644
> --- a/config/rootfiles/common/riscv64/initscripts
> +++ b/config/rootfiles/common/riscv64/initscripts
> @@ -62,6 +62,7 @@ etc/rc.d/init.d/networking/red.up/30-ddns
> #etc/rc.d/init.d/networking/red.up/35-guardian
> etc/rc.d/init.d/networking/red.up/50-ipsec
> etc/rc.d/init.d/networking/red.up/50-ovpn
> +etc/rc.d/init.d/networking/red.up/60-collectd
> etc/rc.d/init.d/networking/red.up/98-leds
> etc/rc.d/init.d/networking/red.up/99-beep
> etc/rc.d/init.d/networking/red.up/99-fireinfo
> diff --git a/config/rootfiles/common/x86_64/initscripts b/config/rootfiles/common/x86_64/initscripts
> index 8a4f046d3..a5e1596fb 100644
> --- a/config/rootfiles/common/x86_64/initscripts
> +++ b/config/rootfiles/common/x86_64/initscripts
> @@ -62,6 +62,7 @@ etc/rc.d/init.d/networking/red.up/30-ddns
> #etc/rc.d/init.d/networking/red.up/35-guardian
> etc/rc.d/init.d/networking/red.up/50-ipsec
> etc/rc.d/init.d/networking/red.up/50-ovpn
> +etc/rc.d/init.d/networking/red.up/60-collectd
> etc/rc.d/init.d/networking/red.up/98-leds
> etc/rc.d/init.d/networking/red.up/99-beep
> etc/rc.d/init.d/networking/red.up/99-fireinfo
> diff --git a/src/initscripts/networking/red.up/60-collectd b/src/initscripts/networking/red.up/60-collectd
> new file mode 100644
> index 000000000..0e457894f
> --- /dev/null
> +++ b/src/initscripts/networking/red.up/60-collectd
> @@ -0,0 +1,6 @@
> +#!/bin/bash
> +
> +# Restart collectd because the ping plugin does not re-resolve "gateway"
> +exec /etc/init.d/collectd restart
> +
> +exit 1
prev parent reply other threads:[~2024-01-14 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:29 Michael Tremer
2024-01-14 16:02 ` Peter Müller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73657096-6c02-4b3f-b72d-6b6d9b142a4a@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox