* Question regarding commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af
@ 2021-09-11 9:45 Peter Müller
2021-09-21 10:11 ` Michael Tremer
0 siblings, 1 reply; 2+ messages in thread
From: Peter Müller @ 2021-09-11 9:45 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
Hello Arne,
by accident, I just came across commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af and this
"diff" output: https://git.ipfire.org/?p=ipfire-2.x.git;a=blobdiff;f=config/rootfiles/oldcore/151/update.sh;h=cec3066c1df423debebecab716f11305e534bdeb;hp=5fb05488b589f0594c96c2ad6e5c67a1ac6d90a9;hb=5b4fc4c8493747af7a6772e1085ef0d45c9ab6af;hpb=c1418e6fc8adc765de60a0c15a977e445c260c72
Frankly, I did not understand why you changed "/etc/init.d/ipsec stop" to "/etc/init.d/ipsec start":
IPsec is started later in this script, if it is enabled, and the comment above reads "stop services".
No offense intended, but is this change intentional? :-)
Thanks, and best regards,
Peter Müller
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question regarding commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af
2021-09-11 9:45 Question regarding commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af Peter Müller
@ 2021-09-21 10:11 ` Michael Tremer
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tremer @ 2021-09-21 10:11 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
This is core update 151?!
> On 11 Sep 2021, at 10:45, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Arne,
>
> by accident, I just came across commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af and this
> "diff" output: https://git.ipfire.org/?p=ipfire-2.x.git;a=blobdiff;f=config/rootfiles/oldcore/151/update.sh;h=cec3066c1df423debebecab716f11305e534bdeb;hp=5fb05488b589f0594c96c2ad6e5c67a1ac6d90a9;hb=5b4fc4c8493747af7a6772e1085ef0d45c9ab6af;hpb=c1418e6fc8adc765de60a0c15a977e445c260c72
>
> Frankly, I did not understand why you changed "/etc/init.d/ipsec stop" to "/etc/init.d/ipsec start":
> IPsec is started later in this script, if it is enabled, and the comment above reads "stop services".
>
> No offense intended, but is this change intentional? :-)
>
> Thanks, and best regards,
> Peter Müller
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-21 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 9:45 Question regarding commit 5b4fc4c8493747af7a6772e1085ef0d45c9ab6af Peter Müller
2021-09-21 10:11 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox