From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 03/13] kernel: Disable IRQ time accounting
Date: Sat, 18 Sep 2021 16:10:10 +0000
Message-ID: <74ece102-9643-804c-784d-1c1f0fc1bbe7@ipfire.org>
In-Reply-To: <20210917114229.10704-3-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3171328387086339748=="
List-Id: <development.lists.ipfire.org>

--===============3171328387086339748==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thanks for cleaning this up. :-)

Acked-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>


> This feature is now disabled (was disabled on ARM before) as we do not
> need it:
>=20
> "Select this option to enable fine granularity task irq time accounting.
> This is done by reading a timestamp on each transitions between softirq
> and hardirq state, so there can be a small performance impact."
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   config/kernel/kernel.config.i586-ipfire   | 2 +-
>   config/kernel/kernel.config.x86_64-ipfire | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel=
.config.i586-ipfire
> index b159db581..ff94e949e 100644
> --- a/config/kernel/kernel.config.i586-ipfire
> +++ b/config/kernel/kernel.config.i586-ipfire
> @@ -103,7 +103,7 @@ CONFIG_PREEMPT_VOLUNTARY=3Dy
>   # CPU/Task time and stats accounting
>   #
>   CONFIG_TICK_CPU_ACCOUNTING=3Dy
> -CONFIG_IRQ_TIME_ACCOUNTING=3Dy
> +# CONFIG_IRQ_TIME_ACCOUNTING is not set
>   CONFIG_HAVE_SCHED_AVG_IRQ=3Dy
>   CONFIG_BSD_PROCESS_ACCT=3Dy
>   # CONFIG_BSD_PROCESS_ACCT_V3 is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index bf738bda5..43c483f00 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -107,7 +107,7 @@ CONFIG_PREEMPT_VOLUNTARY=3Dy
>   #
>   CONFIG_TICK_CPU_ACCOUNTING=3Dy
>   # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set
> -CONFIG_IRQ_TIME_ACCOUNTING=3Dy
> +# CONFIG_IRQ_TIME_ACCOUNTING is not set
>   CONFIG_HAVE_SCHED_AVG_IRQ=3Dy
>   CONFIG_BSD_PROCESS_ACCT=3Dy
>   # CONFIG_BSD_PROCESS_ACCT_V3 is not set
>=20

--===============3171328387086339748==--