From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] Pakfire: do not leak upstream proxy password in log messages
Date: Sat, 11 Apr 2020 11:44:46 +0100 [thread overview]
Message-ID: <752B3419-6CB8-4EF4-8A25-D2AE8C366B21@ipfire.org> (raw)
In-Reply-To: <34570e9e-b21d-52aa-5cb1-8f6477feeae4@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 11 Apr 2020, at 11:20, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> src/pakfire/lib/functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
> index 17a420c33..4d5c6219a 100644
> --- a/src/pakfire/lib/functions.pl
> +++ b/src/pakfire/lib/functions.pl
> @@ -162,7 +162,7 @@ sub fetchfile {
> logger("DOWNLOAD INFO: Upstream proxy: \"$proxysettings{'UPSTREAM_PROXY'}\"");
> if ($proxysettings{'UPSTREAM_USER'}) {
> $ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_USER'}:$proxysettings{'UPSTREAM_PASSWORD'}@"."$proxysettings{'UPSTREAM_PROXY'}/");
> - logger("DOWNLOAD INFO: Logging in with: \"$proxysettings{'UPSTREAM_USER'}\" - \"$proxysettings{'UPSTREAM_PASSWORD'}\"");
> + logger("DOWNLOAD INFO: Logging in with \"$proxysettings{'UPSTREAM_USER'}\" against \"$proxysettings{'UPSTREAM_PROXY'}\"");
> } else {
> $ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_PROXY'}/");
> }
> --
> 2.16.4
prev parent reply other threads:[~2020-04-11 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 10:19 [PATCH 1/2] Pakfire: fix upstream proxy usage Peter Müller
2020-04-11 10:20 ` [PATCH 2/2] Pakfire: do not leak upstream proxy password in log messages Peter Müller
2020-04-11 10:44 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752B3419-6CB8-4EF4-8A25-D2AE8C366B21@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox