From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 2/2] Pakfire: do not leak upstream proxy password in log messages
Date: Sat, 11 Apr 2020 11:44:46 +0100
Message-ID: <752B3419-6CB8-4EF4-8A25-D2AE8C366B21@ipfire.org>
In-Reply-To: <34570e9e-b21d-52aa-5cb1-8f6477feeae4@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0737915226363487934=="
List-Id: <development.lists.ipfire.org>

--===============0737915226363487934==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 11 Apr 2020, at 11:20, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> src/pakfire/lib/functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
> index 17a420c33..4d5c6219a 100644
> --- a/src/pakfire/lib/functions.pl
> +++ b/src/pakfire/lib/functions.pl
> @@ -162,7 +162,7 @@ sub fetchfile {
> 			logger("DOWNLOAD INFO: Upstream proxy: \"$proxysettings{'UPSTREAM_PROXY'=
}\"");
> 			if ($proxysettings{'UPSTREAM_USER'}) {
> 				$ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_USER'}:$=
proxysettings{'UPSTREAM_PASSWORD'}@"."$proxysettings{'UPSTREAM_PROXY'}/");
> -				logger("DOWNLOAD INFO: Logging in with: \"$proxysettings{'UPSTREAM_USE=
R'}\" - \"$proxysettings{'UPSTREAM_PASSWORD'}\"");
> +				logger("DOWNLOAD INFO: Logging in with \"$proxysettings{'UPSTREAM_USER=
'}\" against \"$proxysettings{'UPSTREAM_PROXY'}\"");
> 			} else {
> 				$ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_PROXY'}/=
");
> 			}
> --=20
> 2.16.4


--===============0737915226363487934==--