From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4d31DZ6RdBz2ytH for ; Fri, 07 Nov 2025 14:10:38 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "R12" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4d31DW3jLYz2xPP for ; Fri, 07 Nov 2025 14:10:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4d31DV4LwKz27Z; Fri, 07 Nov 2025 14:10:34 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1762524634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SxBSgF45BmZAYCpWkz9RRmgXQj/qG2rdX8Zbn232ycc=; b=e6RQUGLotJIN/zVoDYHLX5T6CU+PnKvWHqz9Vq6TPQNCj3I7hnWz97YEDCfXVVFOSvSoX5 9Tuj1pvEIOQlpcBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1762524634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SxBSgF45BmZAYCpWkz9RRmgXQj/qG2rdX8Zbn232ycc=; b=AgGW4fr9WWxzk0GTfPRgkuUgdS1sNsOx+DNmGUDTMw8JeDcF4zCNRH/DKYWGm4K4mMaHuU 6k3ghqpFgvI37JZZ3bQu8I/P/s/EWcJmP2oTAu+dgaLDaM24IEzTRADoGOXnaDGxbse0oQ j0bBylk4ryBOOZYQOyYLi2WhfCPOYhW7OrRS8xwKBp6dirykRsXEBsNGfwTAj+eJXjP3Tw KfCoqIWaUxtjZO6h8T1s2GAOQzUm7PdlwDBOFzwxKRoyQBAP4RYoZSd9K3c+2b+PIvNR4U PwJGqeaGME/4xY2KCfprJG6VggLp0I2NIBk7ui8E2+9WeaJ67+tBBrY0/c9JDg== Content-Type: text/plain; charset=utf-8 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH 1/6] lldpd: New package From: Michael Tremer In-Reply-To: Date: Fri, 7 Nov 2025 14:10:34 +0000 Cc: "IPFire: Development-List" Content-Transfer-Encoding: quoted-printable Message-Id: <75B7320F-0C66-4EF9-8D39-AFC23714ABFD@ipfire.org> References: <20251106164907.1484873-1-michael.tremer@ipfire.org> <20251106164907.1484873-2-michael.tremer@ipfire.org> To: Adolf Belka Hello Adolf, > On 6 Nov 2025, at 21:45, Adolf Belka wrote: >=20 > Reviewed-by: Adolf Belka >=20 > Hi Michael, >=20 > llpd has a configure option --disable-static to remove the .a file = from the rootfile. Thank you for this one. I have applied this: = https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D91a6323cfa06= 22a5e8cc198673515d858f36e220 > I am not sure if the doc and man files are doxygen based or not but if = they are then there are also --disable-doxygen-doc and = --disable-doxygen-man options, which would remove those from the = rootfile also. We don=E2=80=99t have doxygen, so they might just be static files which = will just be installed. > If you do edit the file then you could update the year for the LFS = file from 2024 to 2025. Well, I forgot about this one now. I never know what to do with those = headers. -Michael > Regards, >=20 > Adolf. >=20 > On 06/11/2025 17:46, Michael Tremer wrote: >> Signed-off-by: Michael Tremer >> --- >> config/rootfiles/common/lldpd | 25 ++++++++++ >> lfs/lldpd | 87 = +++++++++++++++++++++++++++++++++++ >> make.sh | 1 + >> 3 files changed, 113 insertions(+) >> create mode 100644 config/rootfiles/common/lldpd >> create mode 100644 lfs/lldpd >> diff --git a/config/rootfiles/common/lldpd = b/config/rootfiles/common/lldpd >> new file mode 100644 >> index 000000000..7ead3d00b >> --- /dev/null >> +++ b/config/rootfiles/common/lldpd >> @@ -0,0 +1,25 @@ >> +#etc/lldpd.d >> +#etc/lldpd.d/README.conf >> +#usr/include/lldp-const.h >> +#usr/include/lldpctl.h >> +#usr/include/lldpctl.hpp >> +#usr/lib/liblldpctl.a >> +#usr/lib/liblldpctl.la >> +#usr/lib/liblldpctl.so >> +usr/lib/liblldpctl.so.4 >> +usr/lib/liblldpctl.so.4.10.0 >> +#usr/lib/pkgconfig/lldpctl.pc >> +usr/sbin/lldpcli >> +usr/sbin/lldpctl >> +usr/sbin/lldpd >> +#usr/share/bash-completion/completions/lldpcli >> +#usr/share/doc/lldpd >> +#usr/share/doc/lldpd/CONTRIBUTE.md >> +#usr/share/doc/lldpd/ChangeLog >> +#usr/share/doc/lldpd/LICENSE >> +#usr/share/doc/lldpd/NEWS >> +#usr/share/doc/lldpd/README.md >> +#usr/share/man/man8/lldpcli.8 >> +#usr/share/man/man8/lldpctl.8 >> +#usr/share/man/man8/lldpd.8 >> +#usr/share/zsh/site-functions/_lldpcli >> diff --git a/lfs/lldpd b/lfs/lldpd >> new file mode 100644 >> index 000000000..30302e823 >> --- /dev/null >> +++ b/lfs/lldpd >> @@ -0,0 +1,87 @@ >> = +#########################################################################= ###### >> +# = # >> +# IPFire.org - A linux based firewall = # >> +# Copyright (C) 2007-2024 IPFire Team = # >> +# = # >> +# This program is free software: you can redistribute it and/or = modify # >> +# it under the terms of the GNU General Public License as published = by # >> +# the Free Software Foundation, either version 3 of the License, or = # >> +# (at your option) any later version. = # >> +# = # >> +# This program is distributed in the hope that it will be useful, = # >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of = # >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # >> +# GNU General Public License for more details. = # >> +# = # >> +# You should have received a copy of the GNU General Public License = # >> +# along with this program. If not, see = . # >> +# = # >> = +#########################################################################= ###### >> + >> = +#########################################################################= ###### >> +# Definitions >> = +#########################################################################= ###### >> + >> +include Config >> + >> +VER =3D 1.0.20 >> + >> +THISAPP =3D lldpd-$(VER) >> +DL_FILE =3D $(THISAPP).tar.gz >> +DL_FROM =3D $(URL_IPFIRE) >> +DIR_APP =3D $(DIR_SRC)/$(THISAPP) >> +TARGET =3D $(DIR_INFO)/$(THISAPP) >> + >> = +#########################################################################= ###### >> +# Top-level Rules >> = +#########################################################################= ###### >> + >> +objects =3D $(DL_FILE) >> + >> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >> + >> +$(DL_FILE)_BLAKE2 =3D = 95743f28d9b3c8ad6f354f7def5f835d9b0668c151ad429dccfc7a249e29234a9ca1fda6b3= bcc2890c424053b5adf2d4d9d7c0cb2887e97cc32b42577b91c63a >> + >> +install : $(TARGET) >> + >> +check : $(patsubst %,$(DIR_CHK)/%,$(objects)) >> + >> +download :$(patsubst %,$(DIR_DL)/%,$(objects)) >> + >> +b2 : $(subst %,%_BLAKE2,$(objects)) >> + >> +dist: >> + $(PAK) >> + >> = +#########################################################################= ###### >> +# Downloading, checking, b2sum >> = +#########################################################################= ###### >> + >> +$(patsubst %,$(DIR_CHK)/%,$(objects)) : >> + @$(CHECK) >> + >> +$(patsubst %,$(DIR_DL)/%,$(objects)) : >> + @$(LOAD) >> + >> +$(subst %,%_BLAKE2,$(objects)) : >> + @$(B2SUM) >> + >> = +#########################################################################= ###### >> +# Installation Details >> = +#########################################################################= ###### >> + >> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> + @$(PREBUILD) >> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) >> + cd $(DIR_APP) && ./configure \ >> + --prefix=3D/usr \ >> + --sysconfdir=3D/etc \ >> + --localstatedir=3D/var \ >> + --with-seccomp \ >> + --with-privsep-user=3Dnobody \ >> + --with-privsep-group=3Dnobody \ >> + --without-embedded-libevent >> + cd $(DIR_APP) && make $(MAKETUNING) >> + cd $(DIR_APP) && make install >> + @rm -rf $(DIR_APP) >> + @$(POSTBUILD) >> diff --git a/make.sh b/make.sh >> index b17e90e13..c542c8173 100755 >> --- a/make.sh >> +++ b/make.sh >> @@ -2125,6 +2125,7 @@ build_system() { >> lfsmake2 fort-validator >> lfsmake2 arpwatch >> lfsmake2 suricata-reporter >> + lfsmake2 lldpd >> lfsmake2 linux >> lfsmake2 rtl8812au >=20