From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Trying to update gd Date: Sat, 19 Jun 2021 13:09:27 +0100 Message-ID: <767ECA00-0689-43A9-813D-59694B95CA2D@ipfire.org> In-Reply-To: <939f59ab-2116-7bf4-2c65-0fa73ba4a9d7@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2516113127967570982==" List-Id: --===============2516113127967570982== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, Could you just try putting that filename in quotes? That should work. -Michael > On 18 Jun 2021, at 22:26, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 18/06/2021 10:35, Michael Tremer wrote: >> Hello, >>> On 17 Jun 2021, at 19:53, Adolf Belka wrote: >>>=20 >>> Hi All, >>>=20 >>> I found that gd was at version 2.0.33 from 2006 and there have been sever= al updates all the way up to May this year, some of them to fix bugs or secur= ity concerns. >> Definitely needs an update! >>> So I did a build for version 2.3.1 also taking the opportunity to disable= -static libraries. >>>=20 >>> This built successfully and I also ran the find-dependencies as the libra= ries changed from libgd.so.2.0.0 to libgd.3.0.9 There were no dependencies o= n libgd.so.2 or libgd.2.0.0 >>>=20 >>> As gd is used for the charts I installed the generated iso into a vm on m= y testbed system to confirm they worked. >>>=20 >>> None of the charts showed any data. Also the log pie charts did not work.= The error message from httpd/error_log was:- >>>=20 >>>=20 >>> Can't load '/usr/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi/aut= o/GD/GD.so' for module GD: libtiff.so.5: cannot open shared object file: No s= uch file or directory at /usr/lib/perl5/5.32.1/x86_64-linux-thread-multi/Dyna= Loader.pm line 193. >>> ^@ at /srv/web/ipfire/cgi-bin/getrrdimage.cgi line 24. >>> Compilation failed in require at /srv/web/ipfire/cgi-bin/getrrdimage.cgi = line 24. >>> BEGIN failed--compilation aborted at /srv/web/ipfire/cgi-bin/getrrdimage.= cgi line 24. >>> [Thu Jun 17 16:38:29.559844 2021] [cgid:error] [pid 3156:tid 127227853231= 680] [client 192.168.200.50:49220] End of script output before headers: getrr= dimage.cgi, referer: https://ipfire.localdomain:444/ >>>=20 >>>=20 >>> This seems to be saying it can't find libtiff.so.5 >>>=20 >>> Looking through the source tarballs over time I found that version 2.1.0 = was where it started to look for libtiff. >>>=20 >>> I then installed the libtiff addon in my vm and the charts were all worki= ng. So the new gd requires the libtiff shared object libraries. >>>=20 >>> The addon installs a lot more than just the libtiff so libs so it does no= t seem right to build that structurally into the firewall. >>>=20 >>>=20 >>> The only option I have come up with is to copy the libtiff so's into /usr= /lib/ after the install stage of gd. >>>=20 >>> libtiff is built before gd so the files are available in the build. This = would seem to then provide the required libs without the rest of the libtiff = files. >>>=20 >>> Is this a reasonable approach to use or is there a different method I sho= uld be using. >> Can you not pass something like =E2=80=94-disable-tiff to the configure sc= ript of gd to avoid it linking against libtiff? >> We do not generate any TIFF files here, so it would be safe to disable tha= t functionality. > Thanks very much for the guidance. There was a configure option --without-t= iff so I used that. Built successfully and then tested it in my vm testbed. A= ll charts except memory.cgi work. I need to get more data to confirm that the= log pie charts work. >=20 > With memory.cgi I get an Internal Server Error. The log gives the following= :- >=20 > Bareword "collectd" not allowed while "strict subs" in use at /srv/web/ipfi= re/cgi-bin/memory.cgi line 59. > Bareword "localhost" not allowed while "strict subs" in use at /srv/web/ipf= ire/cgi-bin/memory.cgi line 59. > Bareword "swap" not allowed while "strict subs" in use at /srv/web/ipfire/c= gi-bin/memory.cgi line 59. > Execution of /srv/web/ipfire/cgi-bin/memory.cgi aborted due to compilation = errors. >=20 > Looking at line 59 and checking in git this looks to be related to a change= done by Stefan Schantl 8 days ago > https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D4353c579248b3= 016740252009b4ed15a4c6f8fe3 >=20 > I don't want to commit the patch for gd until I have memory.cgi confirmed w= orking and enough firewall data to confirm the pie charts are working but it = looks close to completion. >=20 > Regards, > Adolf. >=20 >> -Michael >>>=20 >>>=20 >>> Regards, >>>=20 >>> Adolf. >>>=20 >>>=20 >>> --=20 >>> Sent from my laptop --===============2516113127967570982==--