From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: max-clients value has been enhanced
Date: Mon, 10 Aug 2020 14:56:03 +0100
Message-ID: <76BCE156-37FE-479E-AEC9-33E22E7D2465@ipfire.org>
In-Reply-To: <51808fb02046e2fb84914bd63680f2c2cbe4f010.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0222988522786296574=="
List-Id: <development.lists.ipfire.org>

--===============0222988522786296574==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 10 Aug 2020, at 14:49, ummeegge <ummeegge(a)ipfire.org> wrote:
>=20
> Hi Michael,
>=20
> Am Montag, den 10.08.2020, 10:50 +0100 schrieb Michael Tremer:
>> Hello,
>>=20
>> This patch looks good so far.
>>=20
>> But could we also change the numbers in the other transactions? I
>> think that should be fine even without knowledge of those languages.
> If you meant translations ;-)

Yes, sometimes auto-correct makes me sound very stupid.

> i can go into a translator for the rest
> of our languages and try to deliver the rest. To sharpen the language
> quality i would ask then may also in our community platform for some
> corrections...

Changing the number should work. Not sure about all of them, but at least the=
 get the right number even though it might be grammatically incorrect.

-Michael

>=20
>>=20
>> Best,
>> -Michael
>=20
>=20
> Best,
>=20
> Erik
>=20
>=20
>>=20
>>> On 8 Aug 2020, at 07:45, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
>>>=20
>>> The --max-client value has been enhanced from 255 clients to 1024
>>> clients.
>>> Error message gives now explanation if the maximum has been
>>> reached.
>>>=20
>>> Patch has been triggered by=20
>>> https://community.ipfire.org/t/openvpn-max-vpn-clients-quantity-and-conne=
ctions/2925
>>> .
>>>=20
>>> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
>>> ---
>>> html/cgi-bin/ovpnmain.cgi | 2 +-
>>> langs/de/cgi-bin/de.pl    | 2 +-
>>> langs/en/cgi-bin/en.pl    | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>=20
>>> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
>>> index 457ebcf1f..e80ee23a7 100644
>>> --- a/html/cgi-bin/ovpnmain.cgi
>>> +++ b/html/cgi-bin/ovpnmain.cgi
>>> @@ -890,7 +890,7 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-
>>> adv-options'}) {
>>> 	undef $vpnsettings{'ROUTES_PUSH'};
>>> 	&write_routepushfile;
>>>    }
>>> -    if ((length($cgiparams{'MAX_CLIENTS'}) =3D=3D 0) ||
>>> (($cgiparams{'MAX_CLIENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'})
>>>> 255 )) {
>>> +    if ((length($cgiparams{'MAX_CLIENTS'}) =3D=3D 0) ||
>>> (($cgiparams{'MAX_CLIENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'})
>>>> 1024 )) {
>>>        $errormessage =3D $Lang::tr{'invalid input for max clients'};
>>>        goto ADV_ERROR;
>>>    }
>>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
>>> index b01e75eb5..bcea33320 100644
>>> --- a/langs/de/cgi-bin/de.pl
>>> +++ b/langs/de/cgi-bin/de.pl
>>> @@ -1457,7 +1457,7 @@
>>> 'invalid input for keepalive 1:2' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr
>>> Keepalive (mindestens ein Verh=C3=A4ltnis von 1:2)',
>>> 'invalid input for keepalive 2' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Kee=
palive
>>> ping-restart',
>>> 'invalid input for local ip address' =3D> 'Ung=C3=BCltige Eingabe f=C3=BC=
r die
>>> lokale IP-Adresse',
>>> -'invalid input for max clients' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Max
>>> Clients',
>>> +'invalid input for max clients' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Max
>>> Clients. Das Maximum von 1024 Clients wurde =C3=BCberschritten',
>>> 'invalid input for mode' =3D> 'Ung=C3=BCltige Eingabe des Modus',
>>> 'invalid input for name' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr vollen Nam=
en des
>>> Benutzers oder des System Hostnamens',
>>> 'invalid input for oink code' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Oink =
Code',
>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
>>> index 7e3bbec89..95ee46393 100644
>>> --- a/langs/en/cgi-bin/en.pl
>>> +++ b/langs/en/cgi-bin/en.pl
>>> @@ -1481,7 +1481,7 @@
>>> 'invalid input for keepalive 1:2' =3D> 'Invalid input for Keepalive
>>> use at least a ratio of 1:2',
>>> 'invalid input for keepalive 2' =3D> 'Invalid input for Keepalive
>>> ping-restart',
>>> 'invalid input for local ip address' =3D> 'Invalid input for local IP
>>> address',
>>> -'invalid input for max clients' =3D> 'Invalid input for Max
>>> Clients',
>>> +'invalid input for max clients' =3D> 'Invalid input for Max Clients.
>>> The maximum of 1024 clients has been exceeded',
>>> 'invalid input for mode' =3D> 'Invalid input for mode',
>>> 'invalid input for name' =3D> 'Invalid input for user\'s full name or
>>> system hostname',
>>> 'invalid input for oink code' =3D> 'Invalid input for Oink code',
>>> --=20
>>> 2.12.2
>>>=20
>>=20
>>=20
>=20


--===============0222988522786296574==--