From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Change to collectd.conf and collect.custom
Date: Fri, 20 Jan 2023 16:19:25 +0000
Message-ID: <7712A1AE-73DA-4442-B9AC-A76AC99EB014@ipfire.org>
In-Reply-To: <25DFEBB1-D081-4B3C-8F6B-8A12C93A5C59@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6944403336930858525=="
List-Id: <development.lists.ipfire.org>

--===============6944403336930858525==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Can I jump in and ask what you think the purpose of this graph is?

I have no idea what they should tell me. Can we not get rid of them entirely?

I believe the sole reason why those graphs exist is because collectd *can* co=
llect this kind of data. But I have never looked at them and realised like =
=E2=80=9Chey, this does not look right=E2=80=9D=E2=80=A6

-Michael

> On 17 Jan 2023, at 18:34, jon <jon.murphy(a)ipfire.org> wrote:
>=20
> Hello!
>=20
>> On Jan 17, 2023, at 7:50 AM, Bernhard Bitsch <bbitsch(a)ipfire.org> wrote:
>>=20
>> Hi,
>>=20
>> good idea.
>> Why not put these 'addon' definitions into a file /etc/collectd.addons ?
>=20
> Ha! That was my first experiment!
>=20
> jon(a)deb11HPZ:~/dev/ipfire-2.x$ cat config/collectd/collectd.addon
> # Use this file to add add-on processes collectd
>=20
> <Plugin processes>
> Process "smbd"
> Process "nmbd"
> Process "squidguard"
> Process "qemu"
> Process "mpd"
> </Plugin>
> jon(a)deb11HPZ:~/dev/ipfire-2.x$=20
>=20
> I was worried it might cause confusion by adding one more include file.
>=20
>> One problem rermains. services.cgi displays all existent collectd RRDs. Th=
erefore these should be deleted in case of uninstallation of a addon.
>=20
> I did see the delete issue but I am not sure how to clean-up the old RRDs.
>=20
> There is a cron to clean-up year old RRDs:
>=20
> [root(a)ipfire ~] # fcrontab -l | grep -i rrd
> 2023-01-17 11:58:14  INFO listing root's fcrontab
> # Cleanup the collectd RRD (graphs)
> %weekly * * /bin/find /var/log/rrd -mtime +365 -type f -name '*.rrd' -delet=
e -o -type d -empty -delete
> [root(a)ipfire ~] #=20
>=20
> I can easily create=20
> /bin/find /var/log/rrd/collectd/localhost/processes* -mtime 1 -type f -name=
 '*.rrd'
>=20
> But this type of clean-up seems too hacked...
>=20
>=20
>>=20
>> Regards,
>> Bernhard
>>=20
>> Am 17.01.2023 um 05:10 schrieb jon:
>>> All,
>>> I=E2=80=99d like to make a change to the `/etc/collectd.conf` to remove a=
 few monitored processes.  The items appear in the <Plugin processes> section=
 of the config file.  And the processes appear at the bottom of the https://i=
pfire.localdomain:444/cgi-bin/services.cgi WebGUI page.
>>> Why you ask?  Mostly because smbd, nmbd, squidguard, qemu, or mpd are not=
 used (at least by me!).  And so the users of those items are not left out, I=
=E2=80=99d like to move those items to a `collect.custom`.
>>> So overall idea is the core processes would be in `collectd.conf` file.  =
And the add-on processes will be in `collect.custom`.
>>> This is a snip of the plugin process section of the `collectd.conf` file:
>>> ```
>>> <Plugin processes> <Plugin processes>
>>> Process =E2=80=9Csshd" to Process "sshd"
>>> Process =E2=80=9Csmbd" this Process "squid"
>>> Process =E2=80=9Cnmbd=E2=80=9D ---> Process "charon"
>>> Process "squid" Process "openvpn"
>>> Process =E2=80=9Csquidguard" </Plugin>
>>> Process =E2=80=9Ccharon"=20
>>> Process =E2=80=9Copenvpn"=20
>>> Process "qemu"
>>> Process "mpd"
>>> </Plugin>
>>> ```
>>> The items removed from the `collectd.conf` file would move to `collect.cu=
stom`.
>>> <Plugin processes>
>>> Process "smbd"
>>> Process "nmbd"
>>> Process "squidguard"
>>> Process "qemu"
>>> Process "mpd"
>>> </Plugin>
>>> But the problem is I don=E2=80=99t want to overwrite the `/etc/collectd.c=
ustom` file incase an admin has modified it for their own use.
>>> The big question
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>>> So how do I change the `collectd.custom` file in `ipfire-2.x/config/colle=
ctd` AND not overwrite the admin=E2=80=99s `/etc/collectd.custom` file?
>=20


--===============6944403336930858525==--