From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Question about use of xxxMACHINExxx Date: Mon, 08 Jul 2024 16:51:26 +0200 Message-ID: <773ae7c0-d130-401f-b15a-d89f3b9b4cc4@ipfire.org> In-Reply-To: <8A595DF1-45F7-449A-94A0-8A1864D411C6@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2136059515864239658==" List-Id: --===============2136059515864239658== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 08/07/2024 15:59, Michael Tremer wrote: > Hello Adolf, >=20 > Sorry for not being faster at this=E2=80=A6 Still catching up :) No problems. >=20 > This is basically a variable which used to be called MACHINE but was replac= ed with xxxMACHINExxx because the string =E2=80=9CMACHINE=E2=80=9D was actual= ly used in some filename. Not sure I am happy with that name=E2=80=A6 >=20 > When the root files are generated, we don=E2=80=99t replace anything, but i= f we read a rootfile from config/rootfiles, we will replace this variable wit= h the architecture we are building for. Sometimes this method allows us to ha= ve just a generic root file for all architectures, sometimes this does not wo= rk because there are extra files or something like that. >=20 > So when you have such a case, you need to manually replace the architecture= with the placeholder and check if all other architectures generate the same = file. I am not sure that I fully understand. In the repo there are rootfiles in con= fig/rootfiles/common/aarch64/ such as boost, dtc, gcc which have aarch64 in t= he rootfile. None of these have been replaced by xxxMACGHINExxx. In config/rootfiles/packages/aarch64/samba all the aarch64 references are sti= ll present. In /config/rootfiles/packages/x86_64/samba, all the references to= x86_64 are replaced by xxxMACHINExxx as that is what I have been doing. If the samba rootfile in aarch64 should have all its aarch64 references repla= ced by xxxMACHINExxx then that has not been happening and is also not the cas= e for rootfiles in config/rootfiles/common/x86_64/ such as gcc, grub, rust etc If the rootfiles that are in the x86_64 and aarch64 directories should have t= he architecture name replaced by xxxMACHINExxx then I need to do a v2 version= of the samba update I just sent out earlier today as the x86_64 and aarch64 = rootfiles do not have xxxMACHINExxx replacing the architecture reference. Regards, Adolf. >=20 > -Michael >=20 >> On 5 Jul 2024, at 11:39, Adolf Belka wrote: >> >> Hi All, >> >> When a rootfile is in one of the specific architecture directories, e.g. a= arch64 do all the aarch64 references just get left as that or should they get= changed to xxxMACHINExxx. >> >> Looking at some files in the directories it looks like they get left alone= but when I have done the samba rootfile update for x86_64 I have , most time= s, changed any x86_64 reference to xxxMACHINExxx. >> >> What is the correct approach so I don't go messing things up. >> >> Regards, >> >> Adolf >> >=20 --===============2136059515864239658==--