From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Question regarding lines 3603 to 3613 in proxy.cgi
Date: Mon, 05 Apr 2021 13:35:28 +0200
Message-ID: <77634c01-f184-56cc-49f6-b1409015fe94@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9166872310713653436=="
List-Id: <development.lists.ipfire.org>

--===============9166872310713653436==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello development folks,

since I am currently working on a patch(set?) allowing to enable the web prox=
y for ORANGE
through the web interface, I stumbled across lines 3603 to 3613 in the proxy.=
cgi file:

> 	if ($netsettings{'BLUE_DEV'})
> 	{
> 		print FILE "delay_access 1 allow IPFire_green_network";
> 		if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; }
> 		print FILE "\n";
> 		print FILE "delay_access 1 deny  all\n";
> 	} else {
> 		print FILE "delay_access 1 allow all";
> 		if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; }
> 		print FILE "\n";
> 	}

This block appears odd to me, particularly due to the block in lines 3615 to =
3625:

> 	if ($netsettings{'BLUE_DEV'})
> 	{
> 		print FILE "delay_access 2 deny  IPFire_ips\n";
> 		if (!-z $acl_src_unrestricted_ip)  { print FILE "delay_access 2 deny  IPF=
ire_unrestricted_ips\n"; }
> 		if (!-z $acl_src_unrestricted_mac) { print FILE "delay_access 2 deny  IPF=
ire_unrestricted_mac\n"; }
> 		if (($proxysettings{'AUTH_METHOD'} eq 'ncsa') && (!-z $extgrp)) { print F=
ILE "delay_access 2 deny  for_extended_users\n"; }
> 		print FILE "delay_access 2 allow IPFire_blue_network";
> 		if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; }
> 		print FILE "\n";
> 		print FILE "delay_access 2 deny  all\n";
> 	}

While the entire CGI is rather - um - hacky at some points, I suspect the fir=
st code block
to be related to throttling on GREEN, which is not involved into the presence=
 or absence of
the BLUE interface. Or am I missing something here?

Thanks, and best regards,
Peter M=C3=BCller

--===============9166872310713653436==--