From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] extrahd.cgi: Requires "auto" as hidden FS type to mount a
 new device
Date: Tue, 27 Jun 2023 18:29:31 +0100
Message-ID: <777AF9E7-D734-4934-8599-8070CCF2F63D@ipfire.org>
In-Reply-To: <20230626094059.2763-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3970229524903330330=="
List-Id: <development.lists.ipfire.org>

--===============3970229524903330330==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Stefan,

Thank you for the patch.

It kind of solves the problem, but allows a user to write arbitrary values in=
to the configuration file which we don=E2=80=99t want. That value is not bein=
g read anywhere, but I still think we should be rather careful here and just =
fill the field with an empty string on the server side.

We can however let the client sent the =E2=80=9CFS=E2=80=9D parameter if that=
 is at any other point convenient for you.

-Michael

> On 26 Jun 2023, at 10:40, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> html/cgi-bin/extrahd.cgi | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index bb67b792d..08d62172d 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -305,6 +305,7 @@ END
> } else {
> unless($disabled) {
> print "<input type=3D'hidden' name=3D'ACTION' value=3D'$Lang::tr{'add'}'>\n=
";
> + print "<input type=3D'hidden' name=3D'FS' value=3D'auto'>\n";
> print "<img src=3D'/images/updbooster/updxl-led-gray.gif' alt=3D'$Lang::tr{=
'extrahd not configured'}' title=3D'$Lang::tr{'extrahd not configured'}'>&nbs=
p;\n";
> print "<input type=3D'image' alt=3D'$Lang::tr{'add'}' title=3D'$Lang::tr{'a=
dd'}' src=3D'/images/add.gif'>\n";
> }
> --=20
> 2.39.2
>=20


--===============3970229524903330330==--