From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [Patch RFC 08/15] network startup: Always cleanup before red gets started
Date: Wed, 24 May 2023 10:00:25 +0100
Message-ID: <778D919A-27C3-474E-ACA9-316045FF348C@ipfire.org>
In-Reply-To: <20230523172314.7826-9-jonatan.schlag@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7789119941597299396=="
List-Id: <development.lists.ipfire.org>

--===============7789119941597299396==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Agreed. Stuff for RED should be in its own script.

> On 23 May 2023, at 18:23, Jonatan Schlag <jonatan.schlag(a)ipfire.org> wrot=
e:
>=20
> There is no sense in doing this only in /etc/init.d/network
> and not in /etc/init.d/networking/red
>=20
> This files should be always deleted before a startup
>=20
> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
> ---
> src/initscripts/networking/red | 3 +++
> src/initscripts/system/network | 6 +-----
> 2 files changed, 4 insertions(+), 5 deletions(-)
>=20
> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
> index 8e41314b6..3873974ea 100644
> --- a/src/initscripts/networking/red
> +++ b/src/initscripts/networking/red
> @@ -80,6 +80,9 @@ fi
>=20
> case "${1}" in
> start)
> + # Remove possible leftover files
> + rm -f /var/ipfire/red/{active,device,dial-on-demand,dns1,dns2,local-ipadd=
ress,remote-ipaddress,resolv.conf}
> +
> if [ "${DEVICE}" !=3D "${GREEN_DEV}" ] && [ "${DEVICE}" !=3D "" ]; then
> boot_mesg "Bringing up the ${DEVICE} interface..."
> boot_mesg_flush
> diff --git a/src/initscripts/system/network b/src/initscripts/system/network
> index b346d487c..9694165f2 100644
> --- a/src/initscripts/system/network
> +++ b/src/initscripts/system/network
> @@ -60,11 +60,7 @@ case "${DO}" in
> [ "$orange" =3D=3D "1" ] && /etc/rc.d/init.d/networking/orange start
>=20
> # RED
> - if [ "$red" =3D=3D "1" ]; then
> - # Remove possible leftover files
> - rm -f /var/ipfire/red/{active,device,dial-on-demand,dns1,dns2,local-ipadd=
ress,remote-ipaddress,resolv.conf}
> - /etc/rc.d/init.d/networking/red start
> - fi
> + [ "$red" =3D=3D "1" ] && /etc/rc.d/init.d/networking/red start
>=20
> boot_mesg "Mounting network file systems..."
> mount -a -O _netdev
> --=20
> 2.30.2
>=20


--===============7789119941597299396==--