From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] core 130: Remove snort settings dir after convert has run.
Date: Mon, 18 Mar 2019 18:57:49 +0000
Message-ID: <78170DA8-81DA-4895-BD9A-617321EB6E28@ipfire.org>
In-Reply-To: <66ff26261095dc31fe9db28fd674d7d2e0e9f568.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4087316644315923961=="
List-Id: <development.lists.ipfire.org>

--===============4087316644315923961==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Almost?

How is this directory removed when a backup was restored?

-Michael

> On 18 Mar 2019, at 18:56, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Hello Michael,
>> Hi,
>>=20
>> What happens when the converter has failed? Is that a possibility?
>=20
> There is almost no risk, that this would be happened.
>=20
> It contains checks if all corresponding files are present and will
> contain the settings from them - I do not see a case where any problems
> can be happen.
>=20
> Best regards,
>=20
> -Stefan
>=20
>>=20
>> -Michael
>>=20
>>> On 18 Mar 2019, at 18:46, Stefan Schantl <stefan.schantl(a)ipfire.org
>>>> wrote:
>>>=20
>>> When all settings have been converted, the files and directory are
>>> not
>>> needed anymore.
>>>=20
>>> If they will be left and at a later time an backup will be
>>> restored, the
>>> converter will be started by the backup script again and would be
>>> restore those
>>> old snort settings and replace the current IPS settings.
>>>=20
>>> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
>>> ---
>>> config/rootfiles/core/130/update.sh | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>=20
>>> diff --git a/config/rootfiles/core/130/update.sh
>>> b/config/rootfiles/core/130/update.sh
>>> index d33321c32..f3dc0d85a 100644
>>> --- a/config/rootfiles/core/130/update.sh
>>> +++ b/config/rootfiles/core/130/update.sh
>>> @@ -74,6 +74,9 @@ ldconfig
>>> # Migrate snort configuration to suricata
>>> /usr/sbin/convert-snort
>>>=20
>>> +# Remove snort settings
>>> +rm -rvf /var/ipfire/snort
>>> +
>>> # Start services
>>> /etc/init.d/collectd restart
>>> /etc/init.d/firewall restart
>>> --=20
>>> 2.20.1
>>>=20


--===============4087316644315923961==--