Re: [FEATURE] Zone configuration

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 4866 bytes --]

Hey,

Thank you Florian. All merged.

-Michael

P.S. You forgot to CC the list...

> On 19 May 2019, at 22:34, Florian Bührle <erdlof(a)protonmail.com> wrote:
> 
> Hey,
> 
> sorry for my late response :)
> 
> I think you both are right regarding switching the rows/columns. I'm glad to announce that I just finished implementing all your proposed changes so the new version can be shipped with Core 132.
> 
> Regards
> Florian
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> Am Freitag, 17. Mai 2019 23:38 schrieb Michael Tremer <michael.tremer(a)ipfire.org>:
> 
>> Hey guys,
>> 
>> Great work here :)
>> 
>> I talked to Florian in private and said that I do not think it is a good idea to swap the columns. I have no idea what I was thinking there. Of course it makes sense. Must have switched my brain off before talking.
>> 
>> I am in favour of this. I just have no idea if we can have this land in Core Update 132 since we have some urgent security stuff in there and Arne wants to close it as soon as possible.
>> 
>> Florian, what is your availability and do you think you can have this done by Monday? No pressure, I do not think it is the end of the world if we ship it like this. Alternatively we can deactivate the menu option so that users won’t see it yet. Whatever you prefer.
>> 
>> Best,
>> -Michael
>> 
>>> On 14 May 2019, at 22:04, Alexander Koch ipfire(a)starkstromkonsument.de wrote:
>>> Hi Florian,
>>> I vote for switching columns/rows. I think a maximum of four columns (or are you planning to extend the zones too?) results in a better usability than an additional horizontal scrollbar. And the other GUI-pages grow vertically too. The Network Settings could be placed in the first row(s), just like a NIC. What about alternating the background colour (light grey/dark gray) of the rows like on the firewall rules and the logs pages?
>>> Different topic, but related to yours: I'm currently running multiple SSIDs with hostapd on my IPFire machines (one for green and one for blue) by creating the bridges in an initscript and editing the hostapd-config manually. Based on your new Zoneconfig-Feature (it creates the bridges required by hostapd and makes things a lot easier) it is possible to write a patch for the wlanap.cgi to implement this properly. Are you or anybody else already working on this? I would join in or start it ...
>>> Regards, Alex
>>> From: Florian Bührle [mailto:erdlof(a)protonmail.com]
>>> Sent: Tuesday, 14 May 2019, 07:23 CEST
>>> To: ipfire(a)starkstromkonsument.de
>>> Cc: development(a)lists.ipfire.org
>>> Subject: [FEATURE] Zone configuration
>>> 
>>>> Hello Alexander,
>>>> thank you for your feedback!
>>>> 
>>>> 1.  Yes, applying these settings requires a restart. I also think we should inform users of that in the GUI.
>>>> 2.  This is actually a major issue. I thought of two possible fixes: either the columns/rows get switched so the table grows vertically; or we introduce a scrollbar. Personally I think a scrollbar would be a better idea as I plan to also introduce network settings to the zoneconf interface so the site could get rather large if a user has many NICs on their machine. Also I think the height of the site should be consistent.
>>>>    What do you think?
>>>> 
>>>> 
>>>> Regards
>>>> Florian
>>>> -------- Original-Nachricht --------
>>>> An 13. Mai 2019, 23:58, Alexander Koch schrieb:
>>>> Hello Florian,
>>>> thank you for providing this new feature. I think it is a big enhancement to the user experience to bring this to the GUI. I tested the current nightly build (next/9d959ac1) and found two little issues:
>>>> • The changes will not be applied until I reboot the machine. Is this the expected behaviour? If yes: I think there should be a hint on the page to inform the user about it and the file /var/run/need_reboot should be created to activate the corresponding banner "An update requires a restart!" in the GUI. Maybe the translations should be updated too. E.g. "An update or config change requires a reboot!
>>>> • If I use the GUI-Theme "ipfire-legacy" and the system has more than three NICSs, the GUI-Content will overlap the sidemenu. I attached a screenshot with this.
>>>> Regards, Alex
>>>> From: Florian Bührle [mailto:erdlof(a)protonmail.com]
>>>> Sent: Saturday, 11 May 2019, 15:57 CEST
>>>> To: development(a)lists.ipfire.org development(a)lists.ipfire.org
>>>> Subject: [FEATURE] Zone configuration
>>>> 
>>>>> Hey all,
>>>>> I made a new web interface that allows users to assign network interfaces to zones. Check out the wiki article https://wiki.ipfire.org/configuration/network/zoneconf.
>>>>> This feature is already part of the "next" branch of the IPFire 2.x main tree. Please review it and check for bugs :)
>>>>> Regards
>>>>> Flo
> 
>