From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [FEATURE] Zone configuration Date: Mon, 20 May 2019 11:01:43 +0100 Message-ID: <78ACDDC7-B4AB-47EA-94C4-DE484D521048@ipfire.org> In-Reply-To: =?utf-8?q?=3C1NqA-MoxYL9i5Ebq9YAEZNIrCVdpgGgh5Zp4M5HGqhQgCcPadF?= =?utf-8?q?fA2xm-saLV8-0F-Y9rNUze2LZhLEK0=5F6vF1dNdRuHmfiYf3QJiYg99j5g=3D=40?= =?utf-8?q?protonmail=2Ecom=3E?= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3031625109317264436==" List-Id: --===============3031625109317264436== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hey, Thank you Florian. All merged. -Michael P.S. You forgot to CC the list... > On 19 May 2019, at 22:34, Florian B=C3=BChrle wro= te: >=20 > Hey, >=20 > sorry for my late response :) >=20 > I think you both are right regarding switching the rows/columns. I'm glad t= o announce that I just finished implementing all your proposed changes so the= new version can be shipped with Core 132. >=20 > Regards > Florian >=20 > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > Am Freitag, 17. Mai 2019 23:38 schrieb Michael Tremer : >=20 >> Hey guys, >>=20 >> Great work here :) >>=20 >> I talked to Florian in private and said that I do not think it is a good i= dea to swap the columns. I have no idea what I was thinking there. Of course = it makes sense. Must have switched my brain off before talking. >>=20 >> I am in favour of this. I just have no idea if we can have this land in Co= re Update 132 since we have some urgent security stuff in there and Arne want= s to close it as soon as possible. >>=20 >> Florian, what is your availability and do you think you can have this done= by Monday? No pressure, I do not think it is the end of the world if we ship= it like this. Alternatively we can deactivate the menu option so that users = won=E2=80=99t see it yet. Whatever you prefer. >>=20 >> Best, >> -Michael >>=20 >>> On 14 May 2019, at 22:04, Alexander Koch ipfire(a)starkstromkonsument.de = wrote: >>> Hi Florian, >>> I vote for switching columns/rows. I think a maximum of four columns (or = are you planning to extend the zones too?) results in a better usability than= an additional horizontal scrollbar. And the other GUI-pages grow vertically = too. The Network Settings could be placed in the first row(s), just like a NI= C. What about alternating the background colour (light grey/dark gray) of the= rows like on the firewall rules and the logs pages? >>> Different topic, but related to yours: I'm currently running multiple SSI= Ds with hostapd on my IPFire machines (one for green and one for blue) by cre= ating the bridges in an initscript and editing the hostapd-config manually. B= ased on your new Zoneconfig-Feature (it creates the bridges required by hosta= pd and makes things a lot easier) it is possible to write a patch for the wla= nap.cgi to implement this properly. Are you or anybody else already working o= n this? I would join in or start it ... >>> Regards, Alex >>> From: Florian B=C3=BChrle [mailto:erdlof(a)protonmail.com] >>> Sent: Tuesday, 14 May 2019, 07:23 CEST >>> To: ipfire(a)starkstromkonsument.de >>> Cc: development(a)lists.ipfire.org >>> Subject: [FEATURE] Zone configuration >>>=20 >>>> Hello Alexander, >>>> thank you for your feedback! >>>>=20 >>>> 1. Yes, applying these settings requires a restart. I also think we sho= uld inform users of that in the GUI. >>>> 2. This is actually a major issue. I thought of two possible fixes: eit= her the columns/rows get switched so the table grows vertically; or we introd= uce a scrollbar. Personally I think a scrollbar would be a better idea as I p= lan to also introduce network settings to the zoneconf interface so the site = could get rather large if a user has many NICs on their machine. Also I think= the height of the site should be consistent. >>>> What do you think? >>>>=20 >>>>=20 >>>> Regards >>>> Florian >>>> -------- Original-Nachricht -------- >>>> An 13. Mai 2019, 23:58, Alexander Koch schrieb: >>>> Hello Florian, >>>> thank you for providing this new feature. I think it is a big enhancemen= t to the user experience to bring this to the GUI. I tested the current night= ly build (next/9d959ac1) and found two little issues: >>>> =E2=80=A2 The changes will not be applied until I reboot the machine. Is= this the expected behaviour? If yes: I think there should be a hint on the p= age to inform the user about it and the file /var/run/need_reboot should be c= reated to activate the corresponding banner "An update requires a restart!" i= n the GUI. Maybe the translations should be updated too. E.g. "An update or c= onfig change requires a reboot! >>>> =E2=80=A2 If I use the GUI-Theme "ipfire-legacy" and the system has more= than three NICSs, the GUI-Content will overlap the sidemenu. I attached a sc= reenshot with this. >>>> Regards, Alex >>>> From: Florian B=C3=BChrle [mailto:erdlof(a)protonmail.com] >>>> Sent: Saturday, 11 May 2019, 15:57 CEST >>>> To: development(a)lists.ipfire.org development(a)lists.ipfire.org >>>> Subject: [FEATURE] Zone configuration >>>>=20 >>>>> Hey all, >>>>> I made a new web interface that allows users to assign network interfac= es to zones. Check out the wiki article https://wiki.ipfire.org/configuration= /network/zoneconf. >>>>> This feature is already part of the "next" branch of the IPFire 2.x mai= n tree. Please review it and check for bugs :) >>>>> Regards >>>>> Flo >=20 >=20 --===============3031625109317264436==--