From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Delete 1024 bit DH-parameter from menu
Date: Tue, 19 Jun 2018 11:31:48 +0100 [thread overview]
Message-ID: <7917d09491273b6d97bf13938dbd1518bece2f73.camel@ipfire.org> (raw)
In-Reply-To: <1529342196-12555-1-git-send-email-erik.kapfer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]
Hello,
this patch is fine, but what do we do with systems that already have a key
generated with that size?
-Michael
On Mon, 2018-06-18 at 19:16 +0200, Erik Kapfer wrote:
> Since OpenVPN-2.4.x do not accepts 1024 bit DH-parameter for security concerns
> anymore,
> it has been removed from the menu.
>
> Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 0bc28ce..4bc3473 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -1291,7 +1291,6 @@ END
> <form method='post'><input type='hidden' name='AREUSURE'
> value='yes' />
> <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
> <select name='DHLENGHT'>
> - <option value='1024'
> $selected{'DHLENGHT'}{'1024'}>1024 $Lang::tr{'bit'} ($Lang::tr{'vpn
> weak'})</option>
> <option value='2048'
> $selected{'DHLENGHT'}{'2048'}>2048 $Lang::tr{'bit'}</option>
> <option value='3072'
> $selected{'DHLENGHT'}{'3072'}>3072 $Lang::tr{'bit'}</option>
> <option value='4096'
> $selected{'DHLENGHT'}{'4096'}>4096 $Lang::tr{'bit'}</option>
> @@ -1973,7 +1972,6 @@ END
> </select></td>
> <tr><td class='base'>$Lang::tr{'ovpn dh'}:</td>
> <td class='base'><select name='DHLENGHT'>
> - <option value='1024'
> $selected{'DHLENGHT'}{'1024'}>1024 $Lang::tr{'bit'} ($Lang::tr{'vpn
> weak'})</option>
> <option value='2048'
> $selected{'DHLENGHT'}{'2048'}>2048 $Lang::tr{'bit'}</option>
> <option value='3072'
> $selected{'DHLENGHT'}{'3072'}>3072 $Lang::tr{'bit'}</option>
> <option value='4096'
> $selected{'DHLENGHT'}{'4096'}>4096 $Lang::tr{'bit'}</option>
next prev parent reply other threads:[~2018-06-19 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 17:16 Erik Kapfer
2018-06-19 10:31 ` Michael Tremer [this message]
2018-06-19 11:58 ` ummeegge
2018-06-19 13:03 ` Michael Tremer
2018-06-19 18:39 ` ummeegge
2018-06-21 9:52 ` ummeegge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7917d09491273b6d97bf13938dbd1518bece2f73.camel@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox