From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Added i586/386 support for GO language required for
 node_exporter.
Date: Fri, 07 May 2021 12:28:25 +0100
Message-ID: <795313B6-4880-4E9C-B694-4EB2FADFA40C@ipfire.org>
In-Reply-To: <20210506194616.2972714-2-holger.sunke@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2331916748612291997=="
List-Id: <development.lists.ipfire.org>

--===============2331916748612291997==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Holger,

Thanks for this patch, but I am afraid it doesn=E2=80=99t do exactly what you=
 intend to do.

> On 6 May 2021, at 20:46, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>=20
> ---
> lfs/Config | 4 ++++
> lfs/go     | 6 +++---
> 2 files changed, 7 insertions(+), 3 deletions(-)
>=20
> diff --git a/lfs/Config b/lfs/Config
> index eadbbc408..4d0f2f00b 100644
> --- a/lfs/Config
> +++ b/lfs/Config
> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
> 	GOARCH =3D arm64
> endif
>=20
> +ifeq "$(BUILD_ARCH)" "i586"
> +	GOARCH =3D 386
> +endif

This is fine.

> +
> ###########################################################################=
####
> # Common Macro Definitions
> ###########################################################################=
####
> diff --git a/lfs/go b/lfs/go
> index 6ebb37080..97effcb84 100644
> --- a/lfs/go
> +++ b/lfs/go
> @@ -28,10 +28,9 @@ VER        =3D 1.15.4
>=20
> THISAPP    =3D go-$(VER)
> DL_FILE    =3D go$(VER).$(GOOS)-$(GOARCH).tar.gz
> -DL_FROM    =3D $(URL_IPFIRE)
> +DL_FROM    =3D https://golang.org/dl/
> DIR_APP    =3D $(DIR_SRC)/go
> TARGET     =3D $(DIR_INFO)/$(THISAPP)
> -SUP_ARCH   =3D x86_64

This however enables Go for all architectures including aarch64 and armv5tel =
which is not what you intend.

The correct solution would be to add i586 to the list of supported architectu=
res.

However, I would object to only add Go for i586 because you personally use IP=
Fire on this architecture (please not Adolf=E2=80=99s remarks on our schedule=
 to discontinue i586). We only build Go for x86_64 because the only package t=
hat uses it is the Amazon SSM agent which is not relevant on any other archit=
ecture. node_exporter seems to be a package that could in theory run on any a=
rchitecture and I feel that we should not discriminate by only building somet=
hing for one architecture because we do not want to test it on any of the oth=
ers.

-Michael

>=20
> ###########################################################################=
####
> # Top-level Rules
> @@ -41,7 +40,8 @@ objects =3D $(DL_FILE)
>=20
> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>=20
> -$(DL_FILE)_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
> +go$(VER).$(GOOS)-386.tar.gz_MD5 =3D 8d1c3539c88710273f61b0c810b7448c
>=20
> install : $(TARGET)
>=20
> --=20
> 2.30.2
>=20


--===============2331916748612291997==--