Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8

Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8

[Adolf Belka]

Hi Erik,

On 13/03/2025 08:25, ummeegge wrote:
> Hi Adolf,
> have seen that you removed the perl-JSON Addon since it is now
> available in Perl´s core modules
> https://patchwork.ipfire.org/project/ipfire/patch/20240914152831.7727-8-adolf.belka@ipfire.org/
> . Perl´s ROOTFILE have the pp.pm
> commented https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/common/perl;h=d4ceb7083ea32ce19c0befef168575696c244dd2;hb=refs/heads/next#l315
> so JSON has now been fully removed from IPFire.
> 
> My question is, was this intended ?

No that was not intended. I obviously missed that.

I will submit a patch to uncomment the lines in the perl rootfile.

Regards,
Adolf.

> 
> Best,
> 
> Erik

Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8

[Adolf Belka]

Hi Erik,

On 17/03/2025 07:33, ummeegge wrote:
> Hello Adolf,
> great thanks. Have seen it also only since i do needed them for a
> project.

It is in CU193 Testing.

Regards,
Adolf.

> 
> Best,
> 
> Erik
> 
> Am Samstag, dem 15.03.2025 um 17:41 +0100 schrieb Adolf Belka:
>> Hi Erik,
>>
>> On 13/03/2025 08:25, ummeegge wrote:
>>> Hi Adolf,
>>> have seen that you removed the perl-JSON Addon since it is now
>>> available in Perl´s core modules
>>> https://patchwork.ipfire.org/project/ipfire/patch/20240914152831.7727-8-adolf.belka@ipfire.org/
>>> . Perl´s ROOTFILE have the pp.pm
>>> commented
>>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/
>>> common/perl;h=d4ceb7083ea32ce19c0befef168575696c244dd2;hb=refs/head
>>> s/next#l315
>>> so JSON has now been fully removed from IPFire.
>>>
>>> My question is, was this intended ?
>>
>> No that was not intended. I obviously missed that.
>>
>> I will submit a patch to uncomment the lines in the perl rootfile.
>>
>> Regards,
>> Adolf.
>>
>>>
>>> Best,
>>>
>>> Erik
>>
> 

Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8

[ummeegge]

Good morning Adolf,
thanks for fixing/extending it. Have searched also for a `use JSON;`
declaration in IPFire since i was not sure if the JSON modul has been
used somewhere as a dependency. In this case the declaration would have
caused errors but i have not found anything in IPFire´s code base.

Best,

Erik

Am Freitag, dem 21.03.2025 um 10:11 +0100 schrieb Adolf Belka:
> Hi Erik,
> 
> On 17/03/2025 07:33, ummeegge wrote:
> > Hello Adolf,
> > great thanks. Have seen it also only since i do needed them for a
> > project.
> 
> It is in CU193 Testing.
> 
> Regards,
> Adolf.
> 
> > 
> > Best,
> > 
> > Erik
> > 
> > Am Samstag, dem 15.03.2025 um 17:41 +0100 schrieb Adolf Belka:
> > > Hi Erik,
> > > 
> > > On 13/03/2025 08:25, ummeegge wrote:
> > > > Hi Adolf,
> > > > have seen that you removed the perl-JSON Addon since it is now
> > > > available in Perl´s core modules
> > > > https://patchwork.ipfire.org/project/ipfire/patch/20240914152831.7727-8-adolf.belka@ipfire.org/
> > > > . Perl´s ROOTFILE have the pp.pm
> > > > commented
> > > > https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/
> > > > common/perl;h=d4ceb7083ea32ce19c0befef168575696c244dd2;hb=refs/
> > > > head
> > > > s/next#l315
> > > > so JSON has now been fully removed from IPFire.
> > > > 
> > > > My question is, was this intended ?
> > > 
> > > No that was not intended. I obviously missed that.
> > > 
> > > I will submit a patch to uncomment the lines in the perl
> > > rootfile.
> > > 
> > > Regards,
> > > Adolf.
> > > 
> > > > 
> > > > Best,
> > > > 
> > > > Erik
> > > 
> > 
> 
> 

Re: Removal of JSON and commit 32c667786c1fb9bf5b0ddf1b091f092fd1ed23b8

[Adolf Belka]

Hi Erik,
On 26/03/2025 07:17, ummeegge wrote:
> Good morning Adolf,
> thanks for fixing/extending it. Have searched also for a `use JSON;`
> declaration in IPFire since i was not sure if the JSON modul has been
> used somewhere as a dependency. In this case the declaration would have
> caused errors but i have not found anything in IPFire´s code base.

It was being used by samba so the use command would be in their code.

Regards,

Adolf.

> 
> Best,
> 
> Erik
> 
> Am Freitag, dem 21.03.2025 um 10:11 +0100 schrieb Adolf Belka:
>> Hi Erik,
>>
>> On 17/03/2025 07:33, ummeegge wrote:
>>> Hello Adolf,
>>> great thanks. Have seen it also only since i do needed them for a
>>> project.
>>
>> It is in CU193 Testing.
>>
>> Regards,
>> Adolf.
>>
>>>
>>> Best,
>>>
>>> Erik
>>>
>>> Am Samstag, dem 15.03.2025 um 17:41 +0100 schrieb Adolf Belka:
>>>> Hi Erik,
>>>>
>>>> On 13/03/2025 08:25, ummeegge wrote:
>>>>> Hi Adolf,
>>>>> have seen that you removed the perl-JSON Addon since it is now
>>>>> available in Perl´s core modules
>>>>> https://patchwork.ipfire.org/project/ipfire/patch/20240914152831.7727-8-adolf.belka@ipfire.org/
>>>>> . Perl´s ROOTFILE have the pp.pm
>>>>> commented
>>>>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/
>>>>> common/perl;h=d4ceb7083ea32ce19c0befef168575696c244dd2;hb=refs/
>>>>> head
>>>>> s/next#l315
>>>>> so JSON has now been fully removed from IPFire.
>>>>>
>>>>> My question is, was this intended ?
>>>>
>>>> No that was not intended. I obviously missed that.
>>>>
>>>> I will submit a patch to uncomment the lines in the perl
>>>> rootfile.
>>>>
>>>> Regards,
>>>> Adolf.
>>>>
>>>>>
>>>>> Best,
>>>>>
>>>>> Erik
>>>>
>>>
>>
>>
> 
>