From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rymes To: development@lists.ipfire.org Subject: Re: [PATCH] Rename misleading "check filesystem" reboot option Date: Fri, 18 Nov 2022 19:15:33 -0500 Message-ID: <799CAA6B-921B-4C5E-8FCC-9F3CEB71FF19@rymes.net> In-Reply-To: <5f773d1f-80a8-66d7-d9eb-5c5e41f7bf92@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1954351050666374009==" List-Id: --===============1954351050666374009== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I would argue that this won=E2=80=99t be helpful for anyone. If you are a per= son that reads =E2=80=9Ccheck filesystem=E2=80=9D and thinks that means =E2= =80=9Crepair filesystem=E2=80=9D, then you=E2=80=99re a person that=E2=80=99l= l read =E2=80=9Crun fsck=E2=80=9D and think it means =E2=80=9Crepair filesyst= em using fsck.=E2=80=9D My suggestion would be to add another menu option that actually does repair t= hings, or to change the name from =E2=80=9Ccheck filesystem=E2=80=9D to =E2= =80=9Ccheck filesystem (no repairs made)=E2=80=9D or something like that. Tom > On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann w= rote: >=20 > =EF=BB=BFYes, this is totally cosmetic. In the past, I have noticed a few f= orum posts where people assumed this button would automatically fix file perm= issions or even configuration issues. I think the new label is clearer and le= aves no room for false expectations. >=20 >> Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: >> I think this are cosmetics. >> The new text adds no new information. 'check filesystem' is a synonym to '= run fsck' in a Linux system, IMHO. >> But if it helps some users, we can change this button text. >>=20 >> Reviewed-by: Bernhard Bitsch >>=20 >>> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: >>> Some users assume that "check filesystem" does more than >>> just trigger a simple "fsck" run. This patch changes the >>> button label to avoid confusion. >>>=20 >>> Signed-off-by: Leo-Andres Hofmann >>> --- >>> langs/de/cgi-bin/de.pl | 2 +- >>> langs/en/cgi-bin/en.pl | 2 +- >>> langs/fr/cgi-bin/fr.pl | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>>=20 >>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl >>> index db7d117b0..110e4ccba 100644 >>> --- a/langs/de/cgi-bin/de.pl >>> +++ b/langs/de/cgi-bin/de.pl >>> @@ -2144,7 +2144,7 @@ >>> 'real address' =3D> 'Reale Addresse', >>> 'reboot' =3D> 'Neustart', >>> 'reboot ask' =3D> 'Neustart?', >>> -'reboot fsck' =3D> 'Neustart & Dateisystem-Test', >>> +'reboot fsck' =3D> 'Neustart & ‘fsck’ ausf=C3=BChren', >>> 'reboot question' =3D> 'Extra Abfrage bei neustart und herunterfahren e= inschalten', >>> 'reboot schedule' =3D> 'Zeitsteuerung f=C3=BCr IPFire Neustarts', >>> 'reboot sure' =3D> 'Sind Sie sicher, dass Sie neustarten wollen?', >>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>> index 60dca5be4..004c64b6a 100644 >>> --- a/langs/en/cgi-bin/en.pl >>> +++ b/langs/en/cgi-bin/en.pl >>> @@ -2198,7 +2198,7 @@ >>> 'real address' =3D> 'Real Address', >>> 'reboot' =3D> 'Reboot', >>> 'reboot ask' =3D> 'Reboot?', >>> -'reboot fsck' =3D> 'Reboot & check filesystem', >>> +'reboot fsck' =3D> 'Reboot & run ‘fsck’', >>> 'reboot question' =3D> 'Extra query for restart and shutdown', >>> 'reboot schedule' =3D> 'Schedule IPFire reboots', >>> 'reboot sure' =3D> 'Are you sure that you want to reboot?', >>> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl >>> index a1643557e..e46c4fa46 100644 >>> --- a/langs/fr/cgi-bin/fr.pl >>> +++ b/langs/fr/cgi-bin/fr.pl >>> @@ -2206,7 +2206,7 @@ >>> 'real address' =3D> 'Adresse r=C3=A9elle', >>> 'reboot' =3D> 'Red=C3=A9marrer', >>> 'reboot ask' =3D> 'Red=C3=A9marrage ?', >>> -'reboot fsck' =3D> 'Red=C3=A9marrer et v=C3=A9rifier le syst=C3=A8me de = fichier', >>> +'reboot fsck' =3D> 'Red=C3=A9marrer et ex=C3=A9cuter ‘fsck’', >>> 'reboot question' =3D> 'Requ=C3=AAte suppl=C3=A9mentaire pour le red=C3= =A9marrage et l\'arr=C3=AAt', >>> 'reboot schedule' =3D> 'Red=C3=A9marrages planifi=C3=A9es d\'IPFire', >>> 'reboot sure' =3D> 'Etes-vous s=C3=BBr de vouloir red=C3=A9marrer ?', --===============1954351050666374009==--