From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] optionsfw.cgi: Cosmetic fix - centered 'Save...' buttons
Date: Mon, 28 Dec 2020 14:21:33 +0100 [thread overview]
Message-ID: <79C18509-5DB1-4139-A7E4-0484969D1339@ipfire.org> (raw)
In-Reply-To: <20201227151636.6210-1-matthias.fischer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
Hi,
> On 27 Dec 2020, at 16:16, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>
> Center 'Save' and 'Save And Restart' buttons as in most of the
> other pages.
Yes that is a good idea.
However, you are changing the string on the button which is not part of any translation.
-Michael
>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/optionsfw.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/optionsfw.cgi b/html/cgi-bin/optionsfw.cgi
> index 8771a85ba..78e7710f5 100644
> --- a/html/cgi-bin/optionsfw.cgi
> +++ b/html/cgi-bin/optionsfw.cgi
> @@ -394,7 +394,7 @@ END
>
> <br />
> <table width='100%' cellspacing='0'>
> -<tr><td align='right'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
> +<tr><td align='center'><form method='post' action='$ENV{'SCRIPT_NAME'}'>
> <input type='submit' name='ACTION' value='$Lang::tr{'save'}' />
> <input type='submit' name='ACTION' value='$Lang::tr{'fw settings save and restart'}' />
> </form></td></tr>
> --
> 2.18.0
>
prev parent reply other threads:[~2020-12-28 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 15:16 Matthias Fischer
2020-12-28 13:21 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79C18509-5DB1-4139-A7E4-0484969D1339@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox