From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: max-clients value has been enhanced
Date: Mon, 10 Aug 2020 10:50:22 +0100 [thread overview]
Message-ID: <7B02E805-BA91-4F27-81D1-2ABCCC9898DE@ipfire.org> (raw)
In-Reply-To: <20200808064555.30933-1-ummeegge@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 3305 bytes --]
Hello,
This patch looks good so far.
But could we also change the numbers in the other transactions? I think that should be fine even without knowledge of those languages.
Best,
-Michael
> On 8 Aug 2020, at 07:45, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
>
> The --max-client value has been enhanced from 255 clients to 1024 clients.
> Error message gives now explanation if the maximum has been reached.
>
> Patch has been triggered by https://community.ipfire.org/t/openvpn-max-vpn-clients-quantity-and-connections/2925 .
>
> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 2 +-
> langs/de/cgi-bin/de.pl | 2 +-
> langs/en/cgi-bin/en.pl | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 457ebcf1f..e80ee23a7 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -890,7 +890,7 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}) {
> undef $vpnsettings{'ROUTES_PUSH'};
> &write_routepushfile;
> }
> - if ((length($cgiparams{'MAX_CLIENTS'}) == 0) || (($cgiparams{'MAX_CLIENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'}) > 255 )) {
> + if ((length($cgiparams{'MAX_CLIENTS'}) == 0) || (($cgiparams{'MAX_CLIENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'}) > 1024 )) {
> $errormessage = $Lang::tr{'invalid input for max clients'};
> goto ADV_ERROR;
> }
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index b01e75eb5..bcea33320 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -1457,7 +1457,7 @@
> 'invalid input for keepalive 1:2' => 'Ungültige Eingabe für Keepalive (mindestens ein Verhältnis von 1:2)',
> 'invalid input for keepalive 2' => 'Ungültige Eingabe für Keepalive ping-restart',
> 'invalid input for local ip address' => 'Ungültige Eingabe für die lokale IP-Adresse',
> -'invalid input for max clients' => 'Ungültige Eingabe für Max Clients',
> +'invalid input for max clients' => 'Ungültige Eingabe für Max Clients. Das Maximum von 1024 Clients wurde überschritten',
> 'invalid input for mode' => 'Ungültige Eingabe des Modus',
> 'invalid input for name' => 'Ungültige Eingabe für vollen Namen des Benutzers oder des System Hostnamens',
> 'invalid input for oink code' => 'Ungültige Eingabe für Oink Code',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 7e3bbec89..95ee46393 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -1481,7 +1481,7 @@
> 'invalid input for keepalive 1:2' => 'Invalid input for Keepalive use at least a ratio of 1:2',
> 'invalid input for keepalive 2' => 'Invalid input for Keepalive ping-restart',
> 'invalid input for local ip address' => 'Invalid input for local IP address',
> -'invalid input for max clients' => 'Invalid input for Max Clients',
> +'invalid input for max clients' => 'Invalid input for Max Clients. The maximum of 1024 clients has been exceeded',
> 'invalid input for mode' => 'Invalid input for mode',
> 'invalid input for name' => 'Invalid input for user\'s full name or system hostname',
> 'invalid input for oink code' => 'Invalid input for Oink code',
> --
> 2.12.2
>
next prev parent reply other threads:[~2020-08-10 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 6:45 Erik Kapfer
2020-08-10 9:50 ` Michael Tremer [this message]
2020-08-10 13:49 ` ummeegge
2020-08-10 13:56 ` Michael Tremer
2020-08-10 17:12 ` [PATCH v2] " Erik Kapfer
2020-08-11 10:57 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7B02E805-BA91-4F27-81D1-2ABCCC9898DE@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox