From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] zoneconf: reduce the width of inputs for vlanid
Date: Mon, 02 Sep 2019 12:32:30 +0100
Message-ID: <7C3C5F1F-0D66-4EF3-A0AD-AFAAC01FDFDC@ipfire.org>
In-Reply-To: <20190901224729.24567-1-ipfire@starkstromkonsument.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8792439194088660532=="
List-Id: <development.lists.ipfire.org>

--===============8792439194088660532==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Just for my own illustration, could you send a screenshot?

Best,
-Michael

> On 1 Sep 2019, at 23:47, Alex Koch <ipfire(a)starkstromkonsument.de> wrote:
>=20
> The inputs for the vlanids are overlapping the borders of their cells (usin=
g a recent Firefox on Linux Mint, Android or Windows 7). This patch fixes thi=
s by limiting the width to a fixed value.
>=20
> Signed-off-by: Alex Koch <ipfire(a)starkstromkonsument.de>
> ---
> html/cgi-bin/zoneconf.cgi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi
> index 40239c14e..6b8642818 100644
> --- a/html/cgi-bin/zoneconf.cgi
> +++ b/html/cgi-bin/zoneconf.cgi
> @@ -93,6 +93,10 @@ my $css =3D <<END
> 		text-align: center;
> 	}
>=20
> +	input.vlanid {
> +		width: 4em;
> +	}
> +
> 	#submit-container {
> 		width: 100%;
> 		padding-top: 20px;
> @@ -432,7 +436,7 @@ foreach (@nics) {
> 					<option value=3D"NATIVE" $access_selected{"NATIVE"}>$Lang::tr{"zonecon=
f access native"}</option>
> 					<option value=3D"VLAN" $access_selected{"VLAN"} $vlan_disabled>$Lang::=
tr{"zoneconf access vlan"}</option>
> 				</select>
> -				<input type=3D"number" id=3D"TAG $uc $mac" name=3D"TAG $uc $mac" min=
=3D"1" max=3D"4095" value=3D"$zone_vlan_id" $field_disabled>
> +				<input type=3D"number" class=3D"vlanid" id=3D"TAG $uc $mac" name=3D"TA=
G $uc $mac" min=3D"1" max=3D"4095" value=3D"$zone_vlan_id" $field_disabled>
> 			</td>
> END
> ;
> --=20
> 2.17.1
>=20


--===============8792439194088660532==--