From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4bQl235BmGz3368 for ; Mon, 23 Jun 2025 10:39:23 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) client-signature RSA-PSS (4096 bits)) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4bQl201h7Vz2xSN for ; Mon, 23 Jun 2025 10:39:20 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4bQl1z1GWYz34p; Mon, 23 Jun 2025 10:39:19 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1750675159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YsMHJVlloICT8g/oxANMYEJCI65Mhbfo4Yop4AFbRss=; b=dWpolJ/eGJlHmcTi6JRRUCecR/O/ebYZw0i7LIFiRd+UDLWyJr5kRz8cIELm6ljHn4qp5w 8v/u6BhgTxj6j0BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1750675159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YsMHJVlloICT8g/oxANMYEJCI65Mhbfo4Yop4AFbRss=; b=K+jmffP1/bXFB0jD5QVFXN3xey76H+Ik229W7adJro+cE2911ht0FzYM76o1V7/KUCNtBH EuBL060pLBeN6U74grj/MsVk11BoSWmVac/RWxr2emNEIyHIIVPFJ6oKCuVlbtbxwhIgIC bNnh4r4xfsr8ctaUYK9cYHr5JfMalKyUtyrkN+c6VwmXfz4fB3GzDQHzFgZUI8VS2zP7R8 vt0KZZeh5Fwl3GFo+gjQeyNbWSEPD43Ox/s0+iJpPqmhaHoS8lYr5e3AmWP6/R8LNqHB9X t1dJbu4Of72NqQkcLf3RLcMto0yvcbQm/gM/yOJSzGDJJZUSgVOcd6uGzG8zsg== Content-Type: text/plain; charset=utf-8 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH v2] setup: v2 Fixes bug10245 - removal of so called non-local network stop From: Michael Tremer In-Reply-To: <20250619160418.2398881-1-adolf.belka@ipfire.org> Date: Mon, 23 Jun 2025 11:39:18 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <7D682067-BC1F-4A7C-B9C1-D67F9CC43A10@ipfire.org> References: <20250619160418.2398881-1-adolf.belka@ipfire.org> To: Adolf Belka Okay. This makes perfect sense. There is no need to stop the network before any changes would be done. I don=E2=80=99t know why I didn=E2=80=99t get it the first time you = posted this. Sorry. -Michael > On 19 Jun 2025, at 17:04, Adolf Belka wrote: >=20 > - In the setup menu if the OK button is pressed when it asks if you = want to change any > of the interfaces then the red, blue and orange interfaces are = stopped. However if > none of the interfaces are changed then the network restart code = does not get used. > - This results in the system ending up with only the green interfrace = being UP and > connected. > - This patch removes the command that stops the red, blue & orange = interfaces but leaves > the green one running. It seems to not bhe needed and if the OK = button is pressed > on the Drivers and card assignments window but no change made then = the IPFire system > is left with only the green interface connected. > - This command has been present since at least Core Update 30 and the = bug was originally > raised in 2012. > - I tested out this v2 code on my vm testbed and everything worked = fine and if any > change was made then when leaving the Networking section the Network = and Unbound were > restarted. >=20 > Fixes: bug10245 > Tested-by: Adolf Belka > Signed-off-by: Adolf Belka > --- > src/setup/networking.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/src/setup/networking.c b/src/setup/networking.c > index 8d398f365..98018b7f6 100644 > --- a/src/setup/networking.c > +++ b/src/setup/networking.c > @@ -420,9 +420,6 @@ int changedrivers(void) > errorbox(_("Unable to open settings file")); > return 0; > } > - if (automode =3D=3D 0) > - runcommandwithstatus("/etc/rc.d/init.d/network stop red blue = orange", > - _("Networking"), _("Restarting non-local network..."), NULL); >=20 > findkey(kv, "CONFIG_TYPE", temp); configtype =3D atol(temp); > if (configtype =3D=3D 1) > --=20 > 2.49.0 >=20 >=20