From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] rsync: Update to 3.2.0
Date: Sun, 21 Jun 2020 22:25:49 +0100
Message-ID: <7E8D3B17-E5E7-4C2F-8ECB-217CE581EFDF@ipfire.org>
In-Reply-To: <20200621162933.20345-1-matthias.fischer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6083350928263519758=="
List-Id: <development.lists.ipfire.org>

--===============6083350928263519758==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for submitting this patch. It looks good.

I would like to ask you to package zstd. It should be part of the core distri=
bution because it is now being used in many places and a really good balance =
between compression ratio and performance.

Would you be up for doing that?

We can merge this patch already and later remove =E2=80=94disable-zstd and re=
lease an update so that rsync can benefit from the library being available.

Best,
-Michael

> On 21 Jun 2020, at 17:29, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> For details see:
> https://download.samba.org/pub/rsync/src/rsync-3.2.0-NEWS
>=20
> In order to use the new xxhash checksum support and zstd compression,
> the corresponding kernel modules would need to be activated.
>=20
> For now, I disabled both with these configure options:
>=20
> ...
> 	--disable-xxhash \
> 	--disable-zstd
> ...
>=20
> I also commented the new 'rsync-ssl' script:
> "The rsync-ssl script helps you to run an rsync copy to/from
> an rsync daemon that requires ssl connections."
>=20
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> config/rootfiles/packages/rsync |  2 ++
> lfs/rsync                       | 17 +++++++++--------
> 2 files changed, 11 insertions(+), 8 deletions(-)
>=20
> diff --git a/config/rootfiles/packages/rsync b/config/rootfiles/packages/rs=
ync
> index 59c8be9f1..5de7fa9ae 100644
> --- a/config/rootfiles/packages/rsync
> +++ b/config/rootfiles/packages/rsync
> @@ -1,3 +1,5 @@
> usr/bin/rsync
> +#usr/bin/rsync-ssl
> +#usr/share/man/man1/rsync-ssl.1
> #usr/share/man/man1/rsync.1
> #usr/share/man/man5/rsyncd.conf.5
> diff --git a/lfs/rsync b/lfs/rsync
> index 342de920b..be693d166 100644
> --- a/lfs/rsync
> +++ b/lfs/rsync
> @@ -1,7 +1,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2020  IPFire Team  <info(a)ipfire.org>               =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -24,7 +24,7 @@
>=20
> include Config
>=20
> -VER        =3D 3.1.3
> +VER        =3D 3.2.0
>=20
> THISAPP    =3D rsync-$(VER)
> DL_FILE    =3D $(THISAPP).tar.gz
> @@ -32,7 +32,7 @@ DL_FROM    =3D $(URL_IPFIRE)
> DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
> TARGET     =3D $(DIR_INFO)/$(THISAPP)
> PROG       =3D rsync
> -PAK_VER    =3D 11
> +PAK_VER    =3D 12
>=20
> DEPS       =3D
>=20
> @@ -44,7 +44,7 @@ objects =3D $(DL_FILE)
>=20
> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>=20
> -$(DL_FILE)_MD5 =3D 1581a588fde9d89f6bc6201e8129afaf
> +$(DL_FILE)_MD5 =3D 768700bc8a555f5fdbc97dac8ebfbdd3
>=20
> install : $(TARGET)
>=20
> @@ -77,11 +77,12 @@ $(subst %,%_MD5,$(objects)) :
> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	@$(PREBUILD)
> 	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> -	cd $(DIR_APP) && ./configure --prefix=3D/usr
> +	cd $(DIR_APP) && ./configure \
> +	--prefix=3D/usr \
> +	--disable-xxhash \
> +	--disable-zstd
> +
> 	cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
> -	#cd $(DIR_APP)/doc && docbook2html rsync.sgml
> 	cd $(DIR_APP) && make install
> -	#cd $(DIR_APP) && install -v -m755 -d /usr/share/doc/rsync-$(VER) &&
> -	#cd $(DIR_APP) && install -v -m644 doc/*.html /usr/share/doc/rsync-$(VER)
> 	@rm -rf $(DIR_APP)
> 	@$(POSTBUILD)
> --=20
> 2.18.0
>=20


--===============6083350928263519758==--