Re: Errors when updating IPFire-3.x pakfire

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 13085 bytes --]

Hello,

Sorry for not getting back quicker on this.

> On 25 Sep 2023, at 17:17, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 25/09/2023 17:15, Michael Tremer wrote:
>> Hello Adolf,
>> I am doing some larger rewrites of some parts of the code. So things might break.
> I suspected so as there were a lot of new variables.
>> However, please pull again and let me know if this problem is fixed for you.
> Have done so and it has built fine.
> 
> I will resist doing a git pull for the moment until you flag up that you have completed your rewrites.

Generally it would be great if you could be on a recent version, because I want to know about the bugs you are running into.

In case something goes wrong, you could simply roll back by a couple of commits and see if the problem disappears.

-Michael

> Regards,
> 
> Adolf.
>> Best,
>> -Michael
>>> On 25 Sep 2023, at 15:47, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> I did a git pull on my IPFire-3.x local repo and a lot of changes were uploaded.
>>> 
>>> I then ran make -j$(nproc) and quite a few errors occurred.
>>> 
>>> I then re-cloned the pakfire repo and went through the whole autogen.sh and configure with no problems but again with the make there were errors as below.
>>> 
>>> Regards,
>>> Adolf
>>> 
>>> 
>>> make -j$(nproc)
>>>   YACC     src/libpakfire/parser/grammar.c
>>> updating src/libpakfire/parser/grammar.h
>>> make --no-print-directory all-recursive
>>> Making all in .
>>>   LEX      src/libpakfire/parser/scanner.c
>>>   CC       src/libpakfire/libpakfire_la-arch.lo
>>>   CC       src/libpakfire/libpakfire_la-archive.lo
>>>   CC       src/libpakfire/libpakfire_la-build.lo
>>>   CC       src/libpakfire/libpakfire_la-cgroup.lo
>>>   CC       src/libpakfire/libpakfire_la-compress.lo
>>>   CC       src/libpakfire/libpakfire_la-config.lo
>>>   CC       src/libpakfire/libpakfire_la-db.lo
>>>   CC       src/libpakfire/libpakfire_la-dependencies.lo
>>>   CC       src/libpakfire/libpakfire_la-digest.lo
>>>   CC       src/libpakfire/libpakfire_la-dist.lo
>>>   CC       src/libpakfire/libpakfire_la-downloader.lo
>>>   CC       src/libpakfire/libpakfire_la-fhs.lo
>>>   CC       src/libpakfire/libpakfire_la-file.lo
>>> src/libpakfire/file.c:90:10: warning: #warning TODO data [-Wcpp]
>>>    90 |         #warning TODO data
>>>       |          ^~~~~~~
>>>   CC       src/libpakfire/libpakfire_la-filelist.lo
>>> src/libpakfire/file.c: In function '__pakfire_file_check_cf_protection_aarch64':
>>> src/libpakfire/file.c:2695:11: warning: #warning TODO [-Wcpp]
>>>  2695 |         # warning TODO
>>>       |           ^~~~~~~
>>>   CC       src/libpakfire/libpakfire_la-jail.lo
>>>   CC       src/libpakfire/libpakfire_la-key.lo
>>>   CC       src/libpakfire/libpakfire_la-linter.lo
>>>   CC       src/libpakfire/libpakfire_la-logging.lo
>>>   CC       src/libpakfire/libpakfire_la-mount.lo
>>>   CC       src/libpakfire/libpakfire_la-package.lo
>>>   CC       src/libpakfire/libpakfire_la-packager.lo
>>>   CC       src/libpakfire/libpakfire_la-packagelist.lo
>>>   CC       src/libpakfire/libpakfire_la-pakfire.lo
>>>   CC       src/libpakfire/libpakfire_la-parser.lo
>>>   CC       src/libpakfire/libpakfire_la-problem.lo
>>>   CC       src/libpakfire/libpakfire_la-progressbar.lo
>>>   CC       src/libpakfire/libpakfire_la-pwd.lo
>>>   CC       src/libpakfire/libpakfire_la-repo.lo
>>>   CC       src/libpakfire/libpakfire_la-repolist.lo
>>>   CC       src/libpakfire/libpakfire_la-scriptlet.lo
>>>   CC       src/libpakfire/libpakfire_la-snapshot.lo
>>>   CC       src/libpakfire/libpakfire_la-solution.lo
>>>   CC       src/libpakfire/libpakfire_la-string.lo
>>>   CC       src/libpakfire/libpakfire_la-transaction.lo
>>>   CC       src/libpakfire/libpakfire_la-ui.lo
>>> src/libpakfire/ui.c:91:34: warning: 'pakfire_ui_append_solution' defined but not used [-Wunused-function]
>>>    91 | static struct pakfire_solution** pakfire_ui_append_solution(
>>>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> src/libpakfire/ui.c:44:12: warning: 'pakfire_ui_enter_number' defined but not used [-Wunused-function]
>>>    44 | static int pakfire_ui_enter_number(struct pakfire* pakfire, const char* question,
>>>       |            ^~~~~~~~~~~~~~~~~~~~~~~
>>>   CC       src/libpakfire/libpakfire_la-util.lo
>>>   CC       src/libpakfire/parser/libpakfire_parser_la-grammar.lo
>>>   CC       src/libpakfire/parser/libpakfire_parser_la-scanner.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-arch.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-archive.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-build.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-cgroup.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-compress.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-config.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-db.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-dependencies.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-digest.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-dist.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-downloader.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-fhs.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-file.lo
>>> src/libpakfire/file.c:90:10: warning: #warning TODO data [-Wcpp]
>>>    90 |         #warning TODO data
>>>       |          ^~~~~~~
>>>   CC       src/libpakfire/libpakfire_internal_la-filelist.lo
>>> src/libpakfire/file.c: In function '__pakfire_file_check_cf_protection_aarch64':
>>> src/libpakfire/file.c:2695:11: warning: #warning TODO [-Wcpp]
>>>  2695 |         # warning TODO
>>>       |           ^~~~~~~
>>>   CC       src/libpakfire/libpakfire_internal_la-jail.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-key.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-linter.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-logging.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-mount.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-package.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-packager.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-packagelist.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-pakfire.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-parser.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-problem.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-progressbar.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-pwd.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-repo.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-repolist.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-scriptlet.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-snapshot.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-solution.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-string.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-transaction.lo
>>>   CC       src/libpakfire/libpakfire_internal_la-ui.lo
>>> src/libpakfire/ui.c:91:34: warning: 'pakfire_ui_append_solution' defined but not used [-Wunused-function]
>>>    91 | static struct pakfire_solution** pakfire_ui_append_solution(
>>>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> src/libpakfire/ui.c:44:12: warning: 'pakfire_ui_enter_number' defined but not used [-Wunused-function]
>>>    44 | static int pakfire_ui_enter_number(struct pakfire* pakfire, const char* question,
>>>       |            ^~~~~~~~~~~~~~~~~~~~~~~
>>>   CC       src/libpakfire/libpakfire_internal_la-util.lo
>>>   CCLD     libpakfire-parser.la
>>>   CC       src/cli/lib/libcli_la-command.lo
>>>   CC       src/cli/lib/libcli_la-dump.lo
>>> src/cli/lib/dump.c: In function 'cli_dump_packagelist':
>>> src/cli/lib/dump.c:53:16: warning: implicit declaration of function 'pakfire_packagelist_walk'; did you mean 'pakfire_packagelist_push'? [-Wimplicit-function-declaration]
>>>    53 |         return pakfire_packagelist_walk(list, __cli_dump_package, &flags);
>>>       |                ^~~~~~~~~~~~~~~~~~~~~~~~
>>>       |                pakfire_packagelist_push
>>> src/cli/lib/dump.c:53:16: warning: nested extern declaration of 'pakfire_packagelist_walk' [-Wnested-externs]
>>>   CCLD     libpakfire.la
>>>   GEN      src/scripts/pakfire-builder
>>>   GEN      src/scripts/pakfire-client
>>>   GEN      src/scripts/pakfire-daemon
>>>   ASCIIDOC man/pakfire.xml
>>>   ASCIIDOC man/pakfire-archive-format.xml
>>>   ASCIIDOC man/pakfire-deps.xml
>>>   GEN      src/systemd/pakfire-daemon.service
>>>   CC       src/cli/pakfire/pakfire-main.o
>>>   CC       src/cli/pakfire/pakfire-check.o
>>>   CC       src/cli/pakfire/pakfire-clean.o
>>>   CC       src/cli/pakfire/pakfire-info.o
>>>   CC       src/cli/pakfire/pakfire-install.o
>>> src/cli/pakfire/install.c: In function ‘parse_argv’:
>>> src/cli/pakfire/install.c:77:53: error: ‘PAKFIRE_JOB_BEST’ undeclared (first use in this function)
>>>    77 |                                 config.job_flags |= PAKFIRE_JOB_BEST;
>>>       | ^~~~~~~~~~~~~~~~
>>> src/cli/pakfire/install.c:77:53: note: each undeclared identifier is reported only once for each function it appears in
>>> src/cli/pakfire/install.c:81:61: error: ‘PAKFIRE_TRANSACTION_ALLOW_DOWNGRADE’ undeclared (first use in this function)
>>>    81 |                                 config.transaction_flags |= PAKFIRE_TRANSACTION_ALLOW_DOWNGRADE;
>>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>   CC       src/cli/pakfire/pakfire-provides.o
>>> src/cli/pakfire/install.c:85:61: error: ‘PAKFIRE_TRANSACTION_ALLOW_UNINSTALL’ undeclared (first use in this function)
>>>    85 |                                 config.transaction_flags |= PAKFIRE_TRANSACTION_ALLOW_UNINSTALL;
>>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> src/cli/pakfire/install.c:89:61: error: ‘PAKFIRE_TRANSACTION_WITHOUT_RECOMMENDED’ undeclared (first use in this function)
>>>    89 |                                 config.transaction_flags |= PAKFIRE_TRANSACTION_WITHOUT_RECOMMENDED;
>>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> src/cli/pakfire/install.c: In function ‘cli_install’:
>>> src/cli/pakfire/install.c:115:13: warning: implicit declaration of function ‘pakfire_transaction_create’; did you mean ‘pakfire_transaction_count’? [-Wimplicit-function-declaration]
>>>   115 |         r = pakfire_transaction_create(&transaction, pakfire, config.transaction_flags);
>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>       |             pakfire_transaction_count
>>> src/cli/pakfire/install.c:115:13: warning: nested extern declaration of ‘pakfire_transaction_create’ [-Wnested-externs]
>>> src/cli/pakfire/install.c:123:21: warning: implicit declaration of function ‘pakfire_transaction_request’; did you mean ‘pakfire_transaction_run’? [-Wimplicit-function-declaration]
>>>   123 |                 r = pakfire_transaction_request(transaction,
>>>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>       |                     pakfire_transaction_run
>>> src/cli/pakfire/install.c:123:21: warning: nested extern declaration of ‘pakfire_transaction_request’ [-Wnested-externs]
>>> src/cli/pakfire/install.c:124:33: error: ‘PAKFIRE_JOB_INSTALL’ undeclared (first use in this function); did you mean ‘PAKFIRE_CLI_INSTALL_H’?
>>>   124 |                                 PAKFIRE_JOB_INSTALL, argv[i], config.job_flags);
>>>       |                                 ^~~~~~~~~~~~~~~~~~~
>>>       |                                 PAKFIRE_CLI_INSTALL_H
>>> src/cli/pakfire/install.c:132:13: warning: implicit declaration of function ‘pakfire_transaction_solve’; did you mean ‘pakfire_transaction_count’? [-Wimplicit-function-declaration]
>>>   132 |         r = pakfire_transaction_solve(transaction, 0, &problems);
>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~
>>>       |             pakfire_transaction_count
>>> src/cli/pakfire/install.c:132:13: warning: nested extern declaration of ‘pakfire_transaction_solve’ [-Wnested-externs]
>>> src/cli/pakfire/install.c:144:13: error: too few arguments to function ‘pakfire_transaction_run’
>>>   144 |         r = pakfire_transaction_run(transaction);
>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~
>>> In file included from src/cli/pakfire/install.c:26:
>>> /usr/include/pakfire/transaction.h:39:5: note: declared here
>>>    39 | int pakfire_transaction_run(struct pakfire_transaction* transaction, int flags);
>>>       |     ^~~~~~~~~~~~~~~~~~~~~~~
>>> make[2]: *** [Makefile:3842: src/cli/pakfire/pakfire-install.o] Error 1
>>> make[2]: *** Waiting for unfinished jobs....
>>> make[1]: *** [Makefile:4602: all-recursive] Error 1
>>> make: *** [Makefile:2118: all] Error 2
>>> 
>>> -- 
>>> Sent from my laptop
>>>