From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 07/11] Kernel: Trigger BUG if data corruption is detected
Date: Wed, 23 Mar 2022 17:53:38 +0000 [thread overview]
Message-ID: <7EE7B118-D360-47F8-88C2-DFE24BBEB920@ipfire.org> (raw)
In-Reply-To: <0588411b-01e1-cb02-0d2f-7e40831b3338@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 3561 bytes --]
I don’t quite follow what the benefit of this is.
The kernel would log something. That is it. Not bad, but I don’t see how this would help.
> On 19 Mar 2022, at 21:10, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Since we cannot trust the kernel to do the right thing (tm) in such a
> situation anymore, triggering a BUG is less bad than running on a kernel
> in an undefined state.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.aarch64-ipfire | 4 ++--
> config/kernel/kernel.config.armv6l-ipfire | 4 ++--
> config/kernel/kernel.config.riscv64-ipfire | 4 ++--
> config/kernel/kernel.config.x86_64-ipfire | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/kernel.config.aarch64-ipfire
> index 356d9051d..06379d544 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -8125,11 +8125,11 @@ CONFIG_STACKTRACE=y
> #
> # Debug kernel data structures
> #
> -# CONFIG_DEBUG_LIST is not set
> +CONFIG_DEBUG_LIST=y
Why did this have to be changed? CONFIG_BUG_ON_DATA_CORRUPTION does not depends on this as far as I can see.
> # CONFIG_DEBUG_PLIST is not set
> # CONFIG_DEBUG_SG is not set
> # CONFIG_DEBUG_NOTIFIERS is not set
> -# CONFIG_BUG_ON_DATA_CORRUPTION is not set
> +CONFIG_BUG_ON_DATA_CORRUPTION=y
> # end of Debug kernel data structures
>
> # CONFIG_DEBUG_CREDENTIALS is not set
> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/kernel.config.armv6l-ipfire
> index 9dab473d4..68e37304a 100644
> --- a/config/kernel/kernel.config.armv6l-ipfire
> +++ b/config/kernel/kernel.config.armv6l-ipfire
> @@ -8091,11 +8091,11 @@ CONFIG_STACKTRACE=y
> #
> # Debug kernel data structures
> #
> -# CONFIG_DEBUG_LIST is not set
> +CONFIG_DEBUG_LIST=y
> # CONFIG_DEBUG_PLIST is not set
> # CONFIG_DEBUG_SG is not set
> # CONFIG_DEBUG_NOTIFIERS is not set
> -# CONFIG_BUG_ON_DATA_CORRUPTION is not set
> +CONFIG_BUG_ON_DATA_CORRUPTION=y
> # end of Debug kernel data structures
>
> # CONFIG_DEBUG_CREDENTIALS is not set
> diff --git a/config/kernel/kernel.config.riscv64-ipfire b/config/kernel/kernel.config.riscv64-ipfire
> index adef88dc9..8cec9a200 100644
> --- a/config/kernel/kernel.config.riscv64-ipfire
> +++ b/config/kernel/kernel.config.riscv64-ipfire
> @@ -6714,11 +6714,11 @@ CONFIG_STACKTRACE=y
> #
> # Debug kernel data structures
> #
> -# CONFIG_DEBUG_LIST is not set
> +CONFIG_DEBUG_LIST=y
> # CONFIG_DEBUG_PLIST is not set
> # CONFIG_DEBUG_SG is not set
> # CONFIG_DEBUG_NOTIFIERS is not set
> -# CONFIG_BUG_ON_DATA_CORRUPTION is not set
> +CONFIG_BUG_ON_DATA_CORRUPTION=y
> # end of Debug kernel data structures
>
> # CONFIG_DEBUG_CREDENTIALS is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kernel.config.x86_64-ipfire
> index 222b2dc53..0c6731bd1 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -7556,11 +7556,11 @@ CONFIG_STACKTRACE=y
> #
> # Debug kernel data structures
> #
> -# CONFIG_DEBUG_LIST is not set
> +CONFIG_DEBUG_LIST=y
> # CONFIG_DEBUG_PLIST is not set
> # CONFIG_DEBUG_SG is not set
> # CONFIG_DEBUG_NOTIFIERS is not set
> -# CONFIG_BUG_ON_DATA_CORRUPTION is not set
> +CONFIG_BUG_ON_DATA_CORRUPTION=y
> # end of Debug kernel data structures
>
> # CONFIG_DEBUG_CREDENTIALS is not set
> --
> 2.34.1
next prev parent reply other threads:[~2022-03-23 17:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 21:08 [PATCH 00/11] Kernel: Improve hardening Peter Müller
2022-03-19 21:08 ` [PATCH 01/11] Kernel: Set CONFIG_ARCH_MMAP_RND_BITS to 32 bits Peter Müller
2022-03-23 11:42 ` Michael Tremer
2022-03-19 21:08 ` [PATCH 02/11] Kernel: Disable support for tracing block I/O actions Peter Müller
2022-03-23 11:44 ` Michael Tremer
2022-03-19 21:09 ` [PATCH 03/11] Kernel: Pin loading kernel files to one filesystem Peter Müller
2022-03-21 17:15 ` Arne Fitzenreiter
2022-03-21 18:50 ` Michael Tremer
2022-03-21 20:24 ` alf
2022-03-22 11:17 ` Michael Tremer
2022-03-19 21:09 ` [PATCH 04/11] Kernel: Enable undefined behaviour sanity checker Peter Müller
2022-03-23 11:45 ` Michael Tremer
2022-03-19 21:09 ` [PATCH 05/11] Kernel: Gate SETID transitions to limit CAP_SET(G|U)ID capabilities Peter Müller
2022-03-23 11:46 ` Michael Tremer
2022-03-19 21:10 ` [PATCH 06/11] Kernel: Enable LSM support and set security level to "integrity" Peter Müller
2022-03-23 17:50 ` Michael Tremer
2022-03-19 21:10 ` [PATCH 07/11] Kernel: Trigger BUG if data corruption is detected Peter Müller
2022-03-23 17:53 ` Michael Tremer [this message]
2022-03-19 21:10 ` [PATCH 08/11] Kernel: Do not automatically load TTY line disciplines, only if necessary Peter Müller
2022-03-23 17:54 ` Michael Tremer
2022-03-19 21:10 ` [PATCH 09/11] Kernel: Enable SVA support for both Intel and AMD CPUs Peter Müller
2022-03-23 17:54 ` Michael Tremer
2022-03-19 21:11 ` [PATCH 10/11] Kernel: Disable function and stack tracers Peter Müller
2022-03-23 17:56 ` Michael Tremer
2022-03-19 21:11 ` [PATCH 11/11] Kernel: Update rootfile for x86_64 Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7EE7B118-D360-47F8-88C2-DFE24BBEB920@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox