[PATCH] make.sh: Clarify options need to come before the actual command

[PATCH] make.sh: Clarify options need to come before the actual command

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

This might prevent some misunderstandings, as the help of make.sh does
not precisely state where the options (target architecture) needs to be
specified.

See: https://lists.ipfire.org/pipermail/development/2022-January/011911.html

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 make.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/make.sh b/make.sh
index 7568ee232..3f45e1953 100755
--- a/make.sh
+++ b/make.sh
@@ -1957,7 +1957,7 @@ check-manualpages)
 	fi
 	;;
 *)
-	echo "Usage: $0 {build|changelog|clean|gettoolchain|downloadsrc|shell|sync|toolchain|update-contributors|find-dependencies|check-manualpages}"
+	echo "Usage: $0 [OPTIONS] {build|changelog|clean|gettoolchain|downloadsrc|shell|sync|toolchain|update-contributors|find-dependencies|check-manualpages}"
 	cat doc/make.sh-usage
 	;;
 esac
-- 
2.26.2

Re: [PATCH] make.sh: Clarify options need to come before the actual command

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 9 Jan 2022, at 12:54, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> This might prevent some misunderstandings, as the help of make.sh does
> not precisely state where the options (target architecture) needs to be
> specified.
> 
> See: https://lists.ipfire.org/pipermail/development/2022-January/011911.html
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> make.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/make.sh b/make.sh
> index 7568ee232..3f45e1953 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1957,7 +1957,7 @@ check-manualpages)
> 	fi
> 	;;
> *)
> -	echo "Usage: $0 {build|changelog|clean|gettoolchain|downloadsrc|shell|sync|toolchain|update-contributors|find-dependencies|check-manualpages}"
> +	echo "Usage: $0 [OPTIONS] {build|changelog|clean|gettoolchain|downloadsrc|shell|sync|toolchain|update-contributors|find-dependencies|check-manualpages}"
> 	cat doc/make.sh-usage
> 	;;
> esac
> -- 
> 2.26.2