From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] getrrdimage.cgi: Add default values to parameters
Date: Wed, 06 Apr 2022 17:07:07 +0000 [thread overview]
Message-ID: <7a21d6b9-91a2-bfaf-3ecc-16b34c7b9595@ipfire.org> (raw)
In-Reply-To: <20220406134652.1506-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> Prevents "use of uninitialized value" warnings when the
> CGI is called with broken undefined GET parameters.
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/getrrdimage.cgi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 26e026bba..6ec91cc92 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -44,9 +44,9 @@ my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
> my $uri = URI->new($ENV{'REQUEST_URI'});
> my %query = $uri->query_form;
>
> -my $origin = lc $query{'origin'}; # lower case
> -my $graph = $query{'graph'};
> -my $range = lc $query{'range'}; # lower case
> +my $origin = lc ($query{'origin'} // ''); # lower case
> +my $graph = $query{'graph'} // '';
> +my $range = lc ($query{'range'} // ''); # lower case
>
> # Check parameters
> unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {
prev parent reply other threads:[~2022-04-06 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 13:46 Leo-Andres Hofmann
2022-04-06 17:07 ` Peter Müller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a21d6b9-91a2-bfaf-3ecc-16b34c7b9595@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox