Question about requirement for make.sh clean and make.sh build

Question about requirement for make.sh clean and make.sh build

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi All,


When I am doing changes to programs and addons then it is clear that I need to do full make.sh clean and make.sh build before doing any commit.


If I am changing language files then I know that I need to run make.sh lang but do I also need to run make.sh clean and make.sh build before the make.sh lang and if I am looking to submit a patch for a .cgi file do I also need to run make.sh clean and make.sh build before doing the git commit on the changed cgi file?


Thanks,

Adolf

Re: Question about requirement for make.sh clean and make.sh build

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hello,

You don’t need to rebuild if you can be sure that all files have been replaced/changed.

I am always trying to rather safe than sorry, so I rather do an extra build instead of breaking the build for somebody else. This doesn’t always work, but I will try.

If I change a CGI file, I copy it manually to the right place, or if there are multiple I figure out which lfs-file is responsible and delete the corresponding log file before I run “./make.sh build” again. Then I will have an ISO with the right content.

Does this answer your question?

-Michael

> On 9 Aug 2021, at 14:42, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi All,
> 
> 
> When I am doing changes to programs and addons then it is clear that I need to do full make.sh clean and make.sh build before doing any commit.
> 
> 
> If I am changing language files then I know that I need to run make.sh lang but do I also need to run make.sh clean and make.sh build before the make.sh lang and if I am looking to submit a patch for a .cgi file do I also need to run make.sh clean and make.sh build before doing the git commit on the changed cgi file?
> 
> 
> Thanks,
> 
> Adolf
>