Re: [PATCH] en.pl: Correct minor typo - bug#12701

public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed

From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] en.pl: Correct minor typo - bug#12701
Date: Sat, 09 Oct 2021 15:31:31 +0200	[thread overview]
Message-ID: <7b7e96aa-6c18-acfd-02f3-affabd67f438@ipfire.org> (raw)
In-Reply-To: <5890F3D6-5169-4E65-889D-4D7C5F709656@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 11666 bytes --]

Hallo,

On 09/10/2021 14:14, Michael Tremer wrote:
> Hello,
> 
> I wanted to respond to the ticket but didn’t have time, yet.
> 
> I think this entire sentence should go. It is useless, as in: Everything else needs additional configuration.
I see what you mean. It applies also to other sections but they don't have any message.
> 
> It does not make much sense to mark this in one field. We should rather use the new feature that Leo proposed where you are being brought to a wiki page which should have all information you need.
With the link from Leo in place then this statement becomes a bit redundant so I would agree with removing it.
I will wait to see the overall decision and redo the patch as appropriate.
> 
> How do we feel about this?
> 
> -Michael
> 
>> On 9 Oct 2021, at 09:31, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - Corrected minor typo in the en.pl file - bug#12701
>>
>> Fixes: 12701
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> doc/language_issues.en | 2 +-
>> doc/language_issues.es | 2 +-
>> doc/language_issues.it | 2 +-
>> doc/language_issues.nl | 2 +-
>> doc/language_issues.pl | 2 +-
>> doc/language_issues.ru | 2 +-
>> doc/language_issues.tr | 2 +-
>> langs/en/cgi-bin/en.pl | 2 +-
>> 8 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/doc/language_issues.en b/doc/language_issues.en
>> index 3d10bebc6..fce67b8eb 100644
>> --- a/doc/language_issues.en
>> +++ b/doc/language_issues.en
>> @@ -299,7 +299,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: age second = second
>> diff --git a/doc/language_issues.es b/doc/language_issues.es
>> index 2e58b5b02..60612f9df 100644
>> --- a/doc/language_issues.es
>> +++ b/doc/language_issues.es
>> @@ -814,7 +814,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: age second = second
>> diff --git a/doc/language_issues.it b/doc/language_issues.it
>> index 4538461c6..af409c1db 100644
>> --- a/doc/language_issues.it
>> +++ b/doc/language_issues.it
>> @@ -903,7 +903,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>> diff --git a/doc/language_issues.nl b/doc/language_issues.nl
>> index 85fdcbe44..e6ad0d425 100644
>> --- a/doc/language_issues.nl
>> +++ b/doc/language_issues.nl
>> @@ -898,7 +898,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>> diff --git a/doc/language_issues.pl b/doc/language_issues.pl
>> index a023bdbee..52b8bd4aa 100644
>> --- a/doc/language_issues.pl
>> +++ b/doc/language_issues.pl
>> @@ -829,7 +829,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: age second = second
>> diff --git a/doc/language_issues.ru b/doc/language_issues.ru
>> index d1abbc4a8..7928cc948 100644
>> --- a/doc/language_issues.ru
>> +++ b/doc/language_issues.ru
>> @@ -825,7 +825,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: age second = second
>> diff --git a/doc/language_issues.tr b/doc/language_issues.tr
>> index a882db069..6ec856e17 100644
>> --- a/doc/language_issues.tr
>> +++ b/doc/language_issues.tr
>> @@ -890,7 +890,7 @@ WARNING: untranslated string: advproxy wpad example dst_noproxy_ip = e.g. 192.16
>> WARNING: untranslated string: advproxy wpad example dst_noproxy_url = e.g. *.ipfire.org*
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_ip = Excluded IP Subnets (one per line)
>> WARNING: untranslated string: advproxy wpad label dst_noproxy_url = Excluded URL s (one per line)
>> -WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> +WARNING: untranslated string: advproxy wpad notice = Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.
>> WARNING: untranslated string: advproxy wpad title = Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)
>> WARNING: untranslated string: advproxy wpad view pac = Open PAC File
>> WARNING: untranslated string: asn lookup failed = AS lookup failed
>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
>> index 679588940..1a7c37294 100644
>> --- a/langs/en/cgi-bin/en.pl
>> +++ b/langs/en/cgi-bin/en.pl
>> @@ -400,7 +400,7 @@
>> 'advproxy wpad example dst_noproxy_url' => 'e.g. *.ipfire.org*',
>> 'advproxy wpad label dst_noproxy_ip' => 'Excluded IP Subnets (one per line)',
>> 'advproxy wpad label dst_noproxy_url' => 'Excluded URL s (one per line)',
>> -'advproxy wpad notice' => 'Notice: For WPAD/PAC to work properly, furtcher changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.',
>> +'advproxy wpad notice' => 'Notice: For WPAD/PAC to work properly, further changes need to be made. Please see the <a href="https://wiki.ipfire.org/configuration/network/proxy/extend/wpad" target="_blank">Wiki</a>.',
>> 'advproxy wpad title' => 'Web Proxy Auto-Discovery Protocol (WPAD) / Proxy Auto-Config (PAC)',
>> 'advproxy wpad view pac' => 'Open PAC File',
>> 'again' => 'Again:',
>> -- 
>> 2.33.0
>>
>

next prev parent reply	other threads:[~2021-10-09 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  8:31 Adolf Belka
2021-10-09 12:14 ` Michael Tremer
2021-10-09 13:31   ` Adolf Belka [this message]
2021-10-14 19:04     ` Michael Tremer
2021-10-14 21:10       ` Adolf Belka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b7e96aa-6c18-acfd-02f3-affabd67f438@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox