From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/4] initscripts: Add generic function to get the
 filesystem type of a volume
Date: Wed, 27 Mar 2024 20:43:31 +0100
Message-ID: <7d5591b4692cd59626f03269f3595398910b6a7f.camel@ipfire.org>
In-Reply-To: <B701088B-90FC-4E2E-AAF8-E25B83AF9E38@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0055636250399706889=="
List-Id: <development.lists.ipfire.org>

--===============0055636250399706889==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Am Mittwoch, dem 27.03.2024 um 10:15 +0000 schrieb Michael Tremer:
> Hello Stefan,
> 
> > On 27 Mar 2024, at 05:15, Stefan Schantl
> > <stefan.schantl(a)ipfire.org> wrote:
> > 
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > src/initscripts/system/functions | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > 
> > diff --git a/src/initscripts/system/functions
> > b/src/initscripts/system/functions
> > index 5a26aef45..0fa825000 100644
> > --- a/src/initscripts/system/functions
> > +++ b/src/initscripts/system/functions
> > @@ -883,3 +883,11 @@ running_on_oci() {
> > # We are not running on OCI
> > return 1
> > }
> > +
> > +volume_fs_type() {
> > + if [ ! -d "${1}" ]; then
> > + return
> > + fi
> > +
> > + echo "$(stat -f --format="%T" ${1})"
> 
> You don’t need to run a sub shell for this and echo the result. It
> would be enough to just call stat with its arguments.

Thanks for pointing this out,

I'll remove the subshell call in a v2 patch.
> 
> > +}
> > -- 
> > 2.39.2
> > 
> 


--===============0055636250399706889==--