* [PATCH] udev: do not generate manpages
@ 2021-05-23 15:46 Peter Müller
2021-05-23 20:28 ` Adolf Belka
2021-05-25 9:53 ` Michael Tremer
0 siblings, 2 replies; 6+ messages in thread
From: Peter Müller @ 2021-05-23 15:46 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
This is probably a typo and was meant to read "--disable-manpages" in
the first place.
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
lfs/udev | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lfs/udev b/lfs/udev
index b578ab54c..11868ffe2 100644
--- a/lfs/udev
+++ b/lfs/udev
@@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
--libexecdir=/lib \
--with-rootprefix= \
--with-rootlibdir=/lib \
- --enable-manpages \
+ --disable-manpages \
--disable-static
cd $(DIR_APP) && make $(MAKETUNING)
--
2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] udev: do not generate manpages
2021-05-23 15:46 [PATCH] udev: do not generate manpages Peter Müller
@ 2021-05-23 20:28 ` Adolf Belka
2021-05-25 9:53 ` Michael Tremer
1 sibling, 0 replies; 6+ messages in thread
From: Adolf Belka @ 2021-05-23 20:28 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
On 23/05/2021 17:46, Peter Müller wrote:
> This is probably a typo and was meant to read "--disable-manpages" in
> the first place.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> lfs/udev | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lfs/udev b/lfs/udev
> index b578ab54c..11868ffe2 100644
> --- a/lfs/udev
> +++ b/lfs/udev
> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> --libexecdir=/lib \
> --with-rootprefix= \
> --with-rootlibdir=/lib \
> - --enable-manpages \
> + --disable-manpages \
> --disable-static
>
> cd $(DIR_APP) && make $(MAKETUNING)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] udev: do not generate manpages
2021-05-23 15:46 [PATCH] udev: do not generate manpages Peter Müller
2021-05-23 20:28 ` Adolf Belka
@ 2021-05-25 9:53 ` Michael Tremer
2021-05-25 19:40 ` Peter Müller
1 sibling, 1 reply; 6+ messages in thread
From: Michael Tremer @ 2021-05-25 9:53 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Hello,
cool. Is the root file update coming in an extra patch?
-Michael
> On 23 May 2021, at 16:46, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> This is probably a typo and was meant to read "--disable-manpages" in
> the first place.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> lfs/udev | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lfs/udev b/lfs/udev
> index b578ab54c..11868ffe2 100644
> --- a/lfs/udev
> +++ b/lfs/udev
> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> --libexecdir=/lib \
> --with-rootprefix= \
> --with-rootlibdir=/lib \
> - --enable-manpages \
> + --disable-manpages \
> --disable-static
>
> cd $(DIR_APP) && make $(MAKETUNING)
> --
> 2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] udev: do not generate manpages
2021-05-25 9:53 ` Michael Tremer
@ 2021-05-25 19:40 ` Peter Müller
2021-05-25 19:57 ` Michael Tremer
0 siblings, 1 reply; 6+ messages in thread
From: Peter Müller @ 2021-05-25 19:40 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Hello Michael,
thanks for your reply.
No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?
Thanks, and best regards,
Peter Müller
> Hello,
>
> cool. Is the root file update coming in an extra patch?
>
> -Michael
>
>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> This is probably a typo and was meant to read "--disable-manpages" in
>> the first place.
>>
>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>> ---
>> lfs/udev | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lfs/udev b/lfs/udev
>> index b578ab54c..11868ffe2 100644
>> --- a/lfs/udev
>> +++ b/lfs/udev
>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>> --libexecdir=/lib \
>> --with-rootprefix= \
>> --with-rootlibdir=/lib \
>> - --enable-manpages \
>> + --disable-manpages \
>> --disable-static
>>
>> cd $(DIR_APP) && make $(MAKETUNING)
>> --
>> 2.26.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] udev: do not generate manpages
2021-05-25 19:40 ` Peter Müller
@ 2021-05-25 19:57 ` Michael Tremer
2021-05-25 20:03 ` Peter Müller
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tremer @ 2021-05-25 19:57 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch?
> On 25 May 2021, at 20:40, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> Hello Michael,
>
> thanks for your reply.
>
> No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?
>
> Thanks, and best regards,
> Peter Müller
>
>> Hello,
>>
>> cool. Is the root file update coming in an extra patch?
>>
>> -Michael
>>
>>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>
>>> This is probably a typo and was meant to read "--disable-manpages" in
>>> the first place.
>>>
>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>> ---
>>> lfs/udev | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lfs/udev b/lfs/udev
>>> index b578ab54c..11868ffe2 100644
>>> --- a/lfs/udev
>>> +++ b/lfs/udev
>>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>> --libexecdir=/lib \
>>> --with-rootprefix= \
>>> --with-rootlibdir=/lib \
>>> - --enable-manpages \
>>> + --disable-manpages \
>>> --disable-static
>>>
>>> cd $(DIR_APP) && make $(MAKETUNING)
>>> --
>>> 2.26.2
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] udev: do not generate manpages
2021-05-25 19:57 ` Michael Tremer
@ 2021-05-25 20:03 ` Peter Müller
0 siblings, 0 replies; 6+ messages in thread
From: Peter Müller @ 2021-05-25 20:03 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
Hello Michael,
hm, interesting. I cannot recall the build on my workstation to complain about changed rootfiles...
May I ask you to fix that for me?
Thanks in advance, sorry, and best regards,
Peter Müller
> The root file contains man-pages. Disabling them should make them disappear, or what is the point of the whole patch?
>
>> On 25 May 2021, at 20:40, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Hello Michael,
>>
>> thanks for your reply.
>>
>> No, as far as I am concerned, this did not induce rootfile changes. Or am I mistaken?
>>
>> Thanks, and best regards,
>> Peter Müller
>>
>>> Hello,
>>>
>>> cool. Is the root file update coming in an extra patch?
>>>
>>> -Michael
>>>
>>>> On 23 May 2021, at 16:46, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>>
>>>> This is probably a typo and was meant to read "--disable-manpages" in
>>>> the first place.
>>>>
>>>> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>> ---
>>>> lfs/udev | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lfs/udev b/lfs/udev
>>>> index b578ab54c..11868ffe2 100644
>>>> --- a/lfs/udev
>>>> +++ b/lfs/udev
>>>> @@ -84,7 +84,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>>> --libexecdir=/lib \
>>>> --with-rootprefix= \
>>>> --with-rootlibdir=/lib \
>>>> - --enable-manpages \
>>>> + --disable-manpages \
>>>> --disable-static
>>>>
>>>> cd $(DIR_APP) && make $(MAKETUNING)
>>>> --
>>>> 2.26.2
>>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-25 20:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 15:46 [PATCH] udev: do not generate manpages Peter Müller
2021-05-23 20:28 ` Adolf Belka
2021-05-25 9:53 ` Michael Tremer
2021-05-25 19:40 ` Peter Müller
2021-05-25 19:57 ` Michael Tremer
2021-05-25 20:03 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox