public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] vulnerabilities.cgi: Use orange instead of blue for mitigated issues
Date: Mon, 10 Jun 2019 19:24:00 +0000	[thread overview]
Message-ID: <7f63ca30-c3cf-e697-4b54-b8669aacc6ef@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

A mitigated (CPU) vulnerability is still present and might be just
harder to exploit. Using blue as colour for them does not illustrate
their dangerousness - orange is a better choice as far as I am
concerned.

Scaring people away from Intel processors will be a completely
unintended side effect. :-)

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
 html/cgi-bin/vulnerabilities.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/cgi-bin/vulnerabilities.cgi b/html/cgi-bin/vulnerabilities.cgi
index a8746c30c..21d963618 100644
--- a/html/cgi-bin/vulnerabilities.cgi
+++ b/html/cgi-bin/vulnerabilities.cgi
@@ -129,7 +129,7 @@ for my $vuln (sort keys %VULNERABILITIES) {
 	} elsif ($status eq "Mitigation") {
 		$status_message = $Lang::tr{'mitigated'};
 		$colour = "white";
-		$bgcolour = ${Header::colourblue};
+		$bgcolour = ${Header::colourorange};
 
 	# Unknown report from kernel
 	} else {
-- 
2.16.4

             reply	other threads:[~2019-06-10 19:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 19:24 Peter Müller [this message]
2019-06-11  9:37 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f63ca30-c3cf-e697-4b54-b8669aacc6ef@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox