[PATCH] configroot: Add in LOGDROPHOSTILExxx values

[PATCH] configroot: Add in LOGDROPHOSTILExxx values

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2085 bytes --]

- I checked out doing a fresh install of CU184 and found that although the
   LOGDROPHOSTILEIN and LOGDROPHOSTILEOUT entries were selected as "on" the values were not
   in the /var/ipfire/optionsfw/settings file.
- After some investigfation I realised that when I created the LOGDROPHOSTILE split into
   incoming and outgoing I had not added them into the configroot lfs file.
- This patch adds the two entries and this was tested out with a fresh install and
   confirmed to update the settings file.

Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 lfs/configroot | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lfs/configroot b/lfs/configroot
index 66efe04b5..9f6c1ff8c 100644
--- a/lfs/configroot
+++ b/lfs/configroot
@@ -1,7 +1,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2023  IPFire Team  <info(a)ipfire.org>                     #
+# Copyright (C) 2007-2024  IPFire Team  <info(a)ipfire.org>                     #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -133,6 +133,8 @@ $(TARGET) :
 	echo  "DROPWIRELESSFORWARD=on"	>> $(CONFIG_ROOT)/optionsfw/settings
 	echo  "DROPSPOOFEDMARTIAN=on"	>> $(CONFIG_ROOT)/optionsfw/settings
 	echo  "DROPHOSTILE=on"		>> $(CONFIG_ROOT)/optionsfw/settings
+	echo  "LOGDROPHOSTILEIN=on"		>> $(CONFIG_ROOT)/optionsfw/settings
+	echo  "LOGDROPHOSTILEOUT=on"	>> $(CONFIG_ROOT)/optionsfw/settings
 	echo  "LOGDROPCTINVALID=on"	>> $(CONFIG_ROOT)/optionsfw/settings
 	echo  "POLICY=MODE2"		>> $(CONFIG_ROOT)/firewall/settings
 	echo  "POLICY1=MODE2"		>> $(CONFIG_ROOT)/firewall/settings
-- 
2.44.0

Re: [PATCH] configroot: Add in LOGDROPHOSTILExxx values

[Bernhard Bitsch]

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 08.04.2024 um 18:57 schrieb Adolf Belka:
> - I checked out doing a fresh install of CU184 and found that although the
>     LOGDROPHOSTILEIN and LOGDROPHOSTILEOUT entries were selected as "on" the values were not
>     in the /var/ipfire/optionsfw/settings file.
> - After some investigfation I realised that when I created the LOGDROPHOSTILE split into
>     incoming and outgoing I had not added them into the configroot lfs file.
> - This patch adds the two entries and this was tested out with a fresh install and
>     confirmed to update the settings file.
> 
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   lfs/configroot | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lfs/configroot b/lfs/configroot
> index 66efe04b5..9f6c1ff8c 100644
> --- a/lfs/configroot
> +++ b/lfs/configroot
> @@ -1,7 +1,7 @@
>   ###############################################################################
>   #                                                                             #
>   # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2023  IPFire Team  <info(a)ipfire.org>                     #
> +# Copyright (C) 2007-2024  IPFire Team  <info(a)ipfire.org>                     #
>   #                                                                             #
>   # This program is free software: you can redistribute it and/or modify        #
>   # it under the terms of the GNU General Public License as published by        #
> @@ -133,6 +133,8 @@ $(TARGET) :
>   	echo  "DROPWIRELESSFORWARD=on"	>> $(CONFIG_ROOT)/optionsfw/settings
>   	echo  "DROPSPOOFEDMARTIAN=on"	>> $(CONFIG_ROOT)/optionsfw/settings
>   	echo  "DROPHOSTILE=on"		>> $(CONFIG_ROOT)/optionsfw/settings
> +	echo  "LOGDROPHOSTILEIN=on"		>> $(CONFIG_ROOT)/optionsfw/settings
> +	echo  "LOGDROPHOSTILEOUT=on"	>> $(CONFIG_ROOT)/optionsfw/settings
>   	echo  "LOGDROPCTINVALID=on"	>> $(CONFIG_ROOT)/optionsfw/settings
>   	echo  "POLICY=MODE2"		>> $(CONFIG_ROOT)/firewall/settings
>   	echo  "POLICY1=MODE2"		>> $(CONFIG_ROOT)/firewall/settings