public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] services.cgi: avoid experimental warnings
Date: Thu, 09 Feb 2023 17:39:00 +0100	[thread overview]
Message-ID: <801C9382-7267-4832-898D-9DE6769F67AA@ipfire.org> (raw)
In-Reply-To: <26DD6931-137C-4EAC-B6FA-667BCFDA9DD7@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Hello,

No, it doesn’t look like it:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=history;f=html/cgi-bin/services.cgi;h=3c0f27f99ff72f9f96132787017f218ea79fbd1a;hb=HEAD

I will merge it into next. As it is only cosmetic, I will avoid rebuilding master for a little while. We will have to do this later on anyways.

-Michael

> On 8 Feb 2023, at 04:29, jon <jon.murphy(a)ipfire.org> wrote:
> 
> Peter,
> 
> Was this patch to be included in CU 173?
> 
> Jon
> 
> 
> Jon Murphy
> jon.murphy(a)ipfire.org
> 
> 
> 
>> On Jan 16, 2023, at 2:34 PM, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>> 
>> - add single line to code: no warnings 'experimental';
>> - corrects this issue:
>>    https://lists.ipfire.org/pipermail/development/2022-December/015113.html
>> 
>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
>> ---
>> html/cgi-bin/services.cgi | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
>> index 3c0f27f99..0d06ab5fe 100644
>> --- a/html/cgi-bin/services.cgi
>> +++ b/html/cgi-bin/services.cgi
>> @@ -21,6 +21,7 @@
>> 
>> use strict;
>> use feature "switch";
>> +no warnings 'experimental';
>> # enable only the following on debugging purpose
>> #use warnings;
>> #use CGI::Carp 'fatalsToBrowser';
>> -- 
>> 2.30.2
>> 
>> 
> 


       reply	other threads:[~2023-02-09 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <26DD6931-137C-4EAC-B6FA-667BCFDA9DD7@ipfire.org>
2023-02-09 16:39 ` Michael Tremer [this message]
     [not found] <D2078C4D-C78B-4E0A-A480-66AD1CFC3A6A@ipfire.org>
2023-01-17 13:33 ` Bernhard Bitsch
2023-01-16 20:34 Jon Murphy
2023-01-16 21:28 ` Bernhard Bitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801C9382-7267-4832-898D-9DE6769F67AA@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox