From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] update-ipblocklists: remove "<INFO> Skipping" log entries
Date: Wed, 05 Jun 2024 11:55:53 +0200
Message-ID: <8099a694-853d-4afe-ae4c-7d5534013be2@ipfire.org>
In-Reply-To: <CD9A7252-72E1-4F4E-B1EB-FECE59C0F7E5@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9053606485307104582=="
List-Id: <development.lists.ipfire.org>

--===============9053606485307104582==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi All,

On 05/06/2024 11:28, Michael Tremer wrote:
> Hello Jon,
>
> Why should this not be logged?
>
> -Michael
>
>> On 4 Jun 2024, at 21:22, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>>
>> - Remove two <INFO> log entries from message log.
>>
>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
>> ---
>> src/scripts/update-ipblocklists | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/scripts/update-ipblocklists b/src/scripts/update-ipblockl=
ists
>> index a17b47999..dddde8d27 100644
>> --- a/src/scripts/update-ipblocklists
>> +++ b/src/scripts/update-ipblocklists
>> @@ -86,7 +86,7 @@ foreach my $blocklist (@blocklists) {
>> # Check if enough time has passed since the last download of the list.
>> if ($time <=3D $holdoff_time) {
>> # To frequent updates, log to syslog.
>> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent upd=
ate attempts!");
>> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent u=
pdate attempts!");
>>
>> # Skip this provider.
>> next;
>> @@ -100,7 +100,7 @@ foreach my $blocklist (@blocklists) {
>> # Handle different return codes.
>> if ($return eq "not_modified") {
>> # Log notice to syslog.
>> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been =
modified!");
>> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not bee=
n modified!");
>> } elsif ($return eq "dl_error") {
>> # Log error to the syslog.
>> &_log_to_syslog("<ERROR> Could not update $blocklist blocklist - Download =
error\!");
The log message about not being modified was what a forum user was able=20
to use to identify that the Alien Vault list had not been updated for at=20
least 17 months.
That information could not be found from the Alien Vault site as there=20
is no timestamp on the file being downloaded to be able to be processed.

I would not want to lose this information otherwise when another=20
provider silently closes their list because they have been taken over or=20
decide to concentrate on funded lists it will prove very hard to figure=20
out if the lists are still active, even more so as more lists get added.

Regards,
Adolf.


>> --=20
>> 2.30.2
>>

--=20
Sent from my laptop


--===============9053606485307104582==--