From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] firewall.cgi: Allow to creating input rules from Orange
 to another zone.
Date: Sat, 17 Jul 2021 13:14:34 +0100
Message-ID: <80F46D94-0E82-49D6-B7C8-2ECD2B9D889A@ipfire.org>
In-Reply-To: <20210716163558.3779-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0348557448101202039=="
List-Id: <development.lists.ipfire.org>

--===============0348557448101202039==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 16 Jul 2021, at 17:35, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> It was not able to create a firewall rule from the orange network to a
> different network address of the firewall. ( For example: Orange -> IPFire'=
s green address)
>=20
> These rules always have been handled as FORWARD rules which is totaly
> wrong.
>=20
> Fixes #12265.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> Tested-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/firewall.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 70dee8d3c..e50a98179 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -247,7 +247,7 @@ if ($fwdfwsettings{'ACTION'} eq 'saverule')
> 		$errormessage=3D$Lang::tr{'fwdfw err same'};
> 	}
> 	# INPUT part
> -	if ($fwdfwsettings{'grp2'} eq 'ipfire' && $fwdfwsettings{$fwdfwsettings{'=
grp1'}} ne 'ORANGE'){
> +	if ($fwdfwsettings{'grp2'} eq 'ipfire') {
> 		$fwdfwsettings{'config'}=3D$configinput;
> 		$fwdfwsettings{'chain'} =3D 'INPUTFW';
> 		$maxkey=3D&General::findhasharraykey(\%configinputfw);
> --=20
> 2.30.2
>=20


--===============0348557448101202039==--