From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] borgbackup: Update to version 1.2.0
Date: Wed, 13 Apr 2022 12:37:31 +0200 [thread overview]
Message-ID: <80f6fc57-8194-5c30-5928-46d409ecd258@ipfire.org> (raw)
In-Reply-To: <06C444C7-82F4-4182-8724-5CD44FF17F57@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 14027 bytes --]
Hi Michael,
On 13/04/2022 10:47, Michael Tremer wrote:
> Hello Adolf,
>
>> On 12 Apr 2022, at 11:32, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> - Update from 1.1.17 to 1.2.0
>> - Update of rootfile
>> - borgbackup now requires the python module pkgconfig, installed as a set with this patch
>> - Changelog
>> Compatibility notes:
>> dropped support / testing for older Pythons, minimum requirement is 3.8. In
>> case your OS does not provide Python >= 3.8, consider using our binary,
>> which does not need an external Python interpreter. Or continue using
>> borg 1.1.x, which is still supported.
>> freeing repository space only happens when “borg compact” is invoked.
>> mount: the default for --numeric-ids is False now (same as borg extract)
>> borg create --noatime is deprecated. Not storing atime is the default
>> behaviour now (use --atime if you want to store the atime).
>> list: corrected mix-up of “isomtime” and “mtime” formats. Previously,
>> “isomtime” was the default but produced a verbose human format, while
>> “mtime” produced a ISO-8601-like format. The behaviours have been swapped
>> (so “mtime” is human, “isomtime” is ISO-like), and the default is now
>> “mtime”. “isomtime” is now a real ISO-8601 format (“T” between date and
>> time, not a space).
>> create/recreate --list: file status for all files used to get announced
>> AFTER the file (with borg < 1.2). Now, file status is announced BEFORE the
>> file contents are processed. If the file status changes later (e.g. due to
>> an error or a content change), the updated/final file status will be
>> printed again.
>> removed deprecated-since-long stuff (deprecated since):
>> command “borg change-passphrase” (2017-02), use “borg key …”
>> option “--keep-tag-files” (2017-01), use “--keep-exclude-tags”
>> option “--list-format” (2017-10), use “--format”
>> option “--ignore-inode” (2017-09), use “--files-cache” w/o “inode”
>> option “--no-files-cache” (2017-09), use “--files-cache=disabled”
>> removed BORG_HOSTNAME_IS_UNIQUE env var. to use borg you must implement one
>> of these 2 scenarios:
>> the combination of FQDN and result of uuid.getnode() must be unique
>> and stable (this should be the case for almost everybody, except
>> when having duplicate FQDN and MAC address or all-zero MAC address)
>> if you are aware that 1) is not the case for you, you must set
>> BORG_HOST_ID env var to something unique.
>> exit with 128 + signal number, #5161. if you have scripts expecting rc == 2
>> for a signal exit, you need to update them to check for >= 128.
>> Fixes:
>> diff: reduce memory consumption, fix is_hardlink_master, #6295
>> compact: fix / improve freeable / freed space log output
>> derive really freed space from quota use before/after, #5679
>> do not say “freeable”, but “maybe freeable” (based on hint, unsure)
>> fix race conditions in internal SaveFile function, #6306 #6028
>> implement internal safe_unlink (was: truncate_and_unlink) function more
>> safely: usually it does not truncate any more, only under “disk full”
>> circumstances and only if there is only one hardlink. see:
>> https://github.com/borgbackup/borg/discussions/6286
>> Other changes:
>> info: use a pre12-meta cache to accelerate stats for borg < 1.2 archives.
>> the first time borg info is invoked on a borg 1.1 repo, it can take a
>> rather long time computing and caching some stats values for 1.1 archives,
>> which borg 1.2 archives have in their archive metadata structure. be
>> patient, esp. if you have lots of old archives. following invocations are
>> much faster due to the cache. related change: add archive name to
>> calc_stats progress display.
>> docs:
>> add borg 1.2 upgrade notes, #6217
>> link to borg placeholders and borg patterns help
>> init: explain the encryption modes better
>> clarify usage of patternfile roots
>> put import-tar docs into same file as export-tar docs
>> explain the difference between a path that ends with or without a slash,
>> #6297
>>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> config/rootfiles/packages/borgbackup | 64 ++++++++++++++++------------
>> lfs/borgbackup | 6 +--
>> 2 files changed, 40 insertions(+), 30 deletions(-)
>>
>> diff --git a/config/rootfiles/packages/borgbackup b/config/rootfiles/packages/borgbackup
>> index dccaf4711..041d9e89a 100644
>> --- a/config/rootfiles/packages/borgbackup
>> +++ b/config/rootfiles/packages/borgbackup
>> @@ -6,33 +6,38 @@ usr/lib/python3.10/site-packages/borg/__main__.py
>> usr/lib/python3.10/site-packages/borg/_version.py
>> #usr/lib/python3.10/site-packages/borg/algorithms
>> usr/lib/python3.10/site-packages/borg/algorithms/__init__.py
>> -usr/lib/python3.10/site-packages/borg/algorithms/checksums.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -#usr/lib/python3.10/site-packages/borg/algorithms/msgpack
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/__init__.py
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/_packer.cpp
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/_packer.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/_unpacker.cpp
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/_unpacker.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/_version.py
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/exceptions.py
>> -usr/lib/python3.10/site-packages/borg/algorithms/msgpack/fallback.py
>> +usr/lib/python3.10/site-packages/borg/algorithms/checksums.cpython-310-x86_64-linux-gnu.so
>> usr/lib/python3.10/site-packages/borg/archive.py
>> usr/lib/python3.10/site-packages/borg/archiver.py
>> usr/lib/python3.10/site-packages/borg/cache.py
>> -usr/lib/python3.10/site-packages/borg/chunker.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/compress.cpython-310-xxxMACHINExxx-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/chunker.cpython-310-x86_64-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/compress.cpython-310-x86_64-linux-gnu.so
>> usr/lib/python3.10/site-packages/borg/constants.py
>> #usr/lib/python3.10/site-packages/borg/crypto
>> usr/lib/python3.10/site-packages/borg/crypto/__init__.py
>> usr/lib/python3.10/site-packages/borg/crypto/file_integrity.py
>> usr/lib/python3.10/site-packages/borg/crypto/key.py
>> usr/lib/python3.10/site-packages/borg/crypto/keymanager.py
>> -usr/lib/python3.10/site-packages/borg/crypto/low_level.cpython-310-xxxMACHINExxx-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/crypto/low_level.cpython-310-x86_64-linux-gnu.so
>> usr/lib/python3.10/site-packages/borg/crypto/nonces.py
>> usr/lib/python3.10/site-packages/borg/fuse.py
>> -usr/lib/python3.10/site-packages/borg/hashindex.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/helpers.py
>> -usr/lib/python3.10/site-packages/borg/item.cpython-310-xxxMACHINExxx-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/fuse_impl.py
>> +usr/lib/python3.10/site-packages/borg/hashindex.cpython-310-x86_64-linux-gnu.so
>> +#usr/lib/python3.10/site-packages/borg/helpers
>> +usr/lib/python3.10/site-packages/borg/helpers/__init__.py
>> +usr/lib/python3.10/site-packages/borg/helpers/checks.py
>> +usr/lib/python3.10/site-packages/borg/helpers/datastruct.py
>> +usr/lib/python3.10/site-packages/borg/helpers/errors.py
>> +usr/lib/python3.10/site-packages/borg/helpers/fs.py
>> +usr/lib/python3.10/site-packages/borg/helpers/manifest.py
>> +usr/lib/python3.10/site-packages/borg/helpers/misc.py
>> +usr/lib/python3.10/site-packages/borg/helpers/msgpack.py
>> +usr/lib/python3.10/site-packages/borg/helpers/parseformat.py
>> +usr/lib/python3.10/site-packages/borg/helpers/process.py
>> +usr/lib/python3.10/site-packages/borg/helpers/progress.py
>> +usr/lib/python3.10/site-packages/borg/helpers/time.py
>> +usr/lib/python3.10/site-packages/borg/helpers/yes.py
>> +usr/lib/python3.10/site-packages/borg/item.cpython-310-x86_64-linux-gnu.so
>
> You re-introduced the architecture name here. x86_64 should be xxxMACHINExxx. What a great variable name :)
Yes I missed that. Will redo the patch set as a v2.
make.sh build must also have missed those, as I would have fixed it if there was a message about that.
I suspect that the whitelisting that was put in to deal with a false alarm that occurred has also covered this situation.
Regards,
Adolf.
>
>> usr/lib/python3.10/site-packages/borg/locking.py
>> usr/lib/python3.10/site-packages/borg/logger.py
>> usr/lib/python3.10/site-packages/borg/lrucache.py
>> @@ -42,9 +47,11 @@ usr/lib/python3.10/site-packages/borg/patterns.py
>> #usr/lib/python3.10/site-packages/borg/platform
>> usr/lib/python3.10/site-packages/borg/platform/__init__.py
>> usr/lib/python3.10/site-packages/borg/platform/base.py
>> -usr/lib/python3.10/site-packages/borg/platform/linux.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/platform/posix.cpython-310-xxxMACHINExxx-linux-gnu.so
>> -usr/lib/python3.10/site-packages/borg/platform/syncfilerange.cpython-310-xxxMACHINExxx-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/platform/linux.cpython-310-x86_64-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/platform/posix.cpython-310-x86_64-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/platform/syncfilerange.cpython-310-x86_64-linux-gnu.so
>> +usr/lib/python3.10/site-packages/borg/platform/xattr.py
>> +usr/lib/python3.10/site-packages/borg/platformflags.py
>> usr/lib/python3.10/site-packages/borg/remote.py
>> usr/lib/python3.10/site-packages/borg/repository.py
>> usr/lib/python3.10/site-packages/borg/selftest.py
>> @@ -58,8 +65,11 @@ usr/lib/python3.10/site-packages/borg/testsuite/benchmark.py
>> usr/lib/python3.10/site-packages/borg/testsuite/cache.py
>> usr/lib/python3.10/site-packages/borg/testsuite/checksums.py
>> usr/lib/python3.10/site-packages/borg/testsuite/chunker.py
>> +usr/lib/python3.10/site-packages/borg/testsuite/chunker_pytest.py
>> +usr/lib/python3.10/site-packages/borg/testsuite/chunker_slow.py
>> usr/lib/python3.10/site-packages/borg/testsuite/compress.py
>> usr/lib/python3.10/site-packages/borg/testsuite/crypto.py
>> +usr/lib/python3.10/site-packages/borg/testsuite/efficient_collection_queue.py
>> usr/lib/python3.10/site-packages/borg/testsuite/file_integrity.py
>> usr/lib/python3.10/site-packages/borg/testsuite/hashindex.py
>> usr/lib/python3.10/site-packages/borg/testsuite/helpers.py
>> @@ -81,11 +91,11 @@ usr/lib/python3.10/site-packages/borg/testsuite/xattr.py
>> usr/lib/python3.10/site-packages/borg/upgrader.py
>> usr/lib/python3.10/site-packages/borg/version.py
>> usr/lib/python3.10/site-packages/borg/xattr.py
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/PKG-INFO
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/SOURCES.txt
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/dependency_links.txt
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/entry_points.txt
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/not-zip-safe
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/requires.txt
>> -usr/lib/python3.10/site-packages/borgbackup-1.1.17-py3.10.egg-info/top_level.txt
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/PKG-INFO
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/SOURCES.txt
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/dependency_links.txt
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/entry_points.txt
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/not-zip-safe
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/requires.txt
>> +#usr/lib/python3.10/site-packages/borgbackup-1.2.0-py3.10.egg-info/top_level.txt
>> diff --git a/lfs/borgbackup b/lfs/borgbackup
>> index 9244900bf..08a3e8ec7 100644
>> --- a/lfs/borgbackup
>> +++ b/lfs/borgbackup
>> @@ -24,7 +24,7 @@
>>
>> include Config
>>
>> -VER = 1.1.17
>> +VER = 1.2.0
>> SUMMARY = Deduplicating backup program with compression and authenticated encryption
>>
>> THISAPP = borgbackup-$(VER)
>> @@ -33,7 +33,7 @@ DL_FROM = $(URL_IPFIRE)
>> DIR_APP = $(DIR_SRC)/$(THISAPP)
>> TARGET = $(DIR_INFO)/$(THISAPP)
>> PROG = borgbackup
>> -PAK_VER = 10
>> +PAK_VER = 11
>>
>> DEPS =
>>
>> @@ -47,7 +47,7 @@ objects = $(DL_FILE)
>>
>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>
>> -$(DL_FILE)_BLAKE2 = 3ceb51f3c2e4ee4e38495ca0bdef2d5c1b30225afe9a3c9987a82f4a1facd4aa203fb21512e655fbbab400bcbd412ff4aefa80242aa21a579e086d38bf3e1078
>> +$(DL_FILE)_BLAKE2 = 9e6cb8d85ca196cbdd6baba694bc7987d63f85d2ba0e25f3ac1e59400882fff71e29b04ca218ee78f23daeb52d13547062b0c80bd0d3f5b460b28b4f274d11ec
>>
>> install : $(TARGET)
>>
>> --
>> 2.35.1
>>
>
prev parent reply other threads:[~2022-04-13 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:32 Adolf Belka
2022-04-12 10:32 ` [PATCH 2/2] python3-pkgconfig: Install this new python module for borgbackup Adolf Belka
2022-04-13 8:47 ` [PATCH 1/2] borgbackup: Update to version 1.2.0 Michael Tremer
2022-04-13 10:37 ` Adolf Belka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f6fc57-8194-5c30-5928-46d409ecd258@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox