From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 2/2] aliases: Don't call arpping to announce new IP addresses
Date: Wed, 06 Jul 2022 09:59:42 +0000
Message-ID: <81b00cb2-9df4-6cec-6b8d-43e793762ee7@ipfire.org>
In-Reply-To: <20220629182724.392049-2-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2875751090531729223=="
List-Id: <development.lists.ipfire.org>

--===============2875751090531729223==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Acked-by: Peter Müller <peter.mueller(a)ipfire.org>

> I am not sure what the rationale is here, but we should probably not do
> this. Other hosts on the network will be able to update their ARP caches
> properly.
> 
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  src/misc-progs/setaliases.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/misc-progs/setaliases.c b/src/misc-progs/setaliases.c
> index 4d59aa0a8..a541a4fd2 100644
> --- a/src/misc-progs/setaliases.c
> +++ b/src/misc-progs/setaliases.c
> @@ -188,11 +188,6 @@ int main(void)
>  			aliasip, red_netmask, intf, SCOPE);
>  		safe_system(command);
>  
> -		// Send an ARP broadcast
> -		snprintf(command, STRING_SIZE-1,
> -				"/usr/sbin/arping -q -c 1 -w 1 -i %s -S %s %s",
> -				intf, aliasip, default_gateway);
> -		safe_system(command);
>  		alias++;
>  	}
>  	return 0;

--===============2875751090531729223==--