Re: [PATCH] Rename misleading "check filesystem" reboot option

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 4709 bytes --]

Hello,

I really like this conversation here :)

> On 20 Nov 2022, at 19:49, Robin Roevens <robin.roevens(a)disroot.org> wrote:
> 
> Maybe "Check filesystem consistency" is more clear ?

I think this would be the clearest option.

However, I do not know why we have this button in the first place. Why would you suspect having an inconsistent file system? And if you do, is this button actually helping?

I am not suggestion to remove it - I am just questioning why we have this and who would use it and when. I just don’t know.

-Michael

> 
> Or just check filesystem like it was and add a clear description on the
> wiki page https://wiki.ipfire.org/configuration/system/shutdown
> 
> Robin
> 
> Tom Rymes schreef op vr 18-11-2022 om 19:15 [-0500]:
>> I would argue that this won’t be helpful for anyone. If you are a
>> person that reads “check filesystem” and thinks that means “repair
>> filesystem”, then you’re a person that’ll read “run fsck” and think
>> it means “repair filesystem using fsck.”
>> 
>> My suggestion would be to add another menu option that actually does
>> repair things, or to change the name from “check filesystem” to
>> “check filesystem (no repairs made)” or something like that.
>> 
>> Tom
>> 
>>> On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann
>>> <hofmann(a)leo-andres.de> wrote:
>>> 
>>> Yes, this is totally cosmetic. In the past, I have noticed a few
>>> forum posts where people assumed this button would automatically
>>> fix file permissions or even configuration issues. I think the new
>>> label is clearer and leaves no room for false expectations.
>>> 
>>>> Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch:
>>>> I think this are cosmetics.
>>>> The new text adds no new information. 'check filesystem' is a
>>>> synonym to 'run fsck' in a Linux system, IMHO.
>>>> But if it helps some users, we can change this button text.
>>>> 
>>>> Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
>>>> 
>>>>> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann:
>>>>> Some users assume that "check filesystem" does more than
>>>>> just trigger a simple "fsck" run. This patch changes the
>>>>> button label to avoid confusion.
>>>>> 
>>>>> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
>>>>> ---
>>>>>   langs/de/cgi-bin/de.pl | 2 +-
>>>>>   langs/en/cgi-bin/en.pl | 2 +-
>>>>>   langs/fr/cgi-bin/fr.pl | 2 +-
>>>>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>>>> 
>>>>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
>>>>> index db7d117b0..110e4ccba 100644
>>>>> --- a/langs/de/cgi-bin/de.pl
>>>>> +++ b/langs/de/cgi-bin/de.pl
>>>>> @@ -2144,7 +2144,7 @@
>>>>>   'real address' => 'Reale Addresse',
>>>>>   'reboot' => 'Neustart',
>>>>>   'reboot ask' => 'Neustart?',
>>>>> -'reboot fsck' => 'Neustart & Dateisystem-Test',
>>>>> +'reboot fsck' => 'Neustart & &lsquo;fsck&rsquo; ausführen',
>>>>>   'reboot question' => 'Extra Abfrage bei neustart und
>>>>> herunterfahren einschalten',
>>>>>   'reboot schedule' => 'Zeitsteuerung für IPFire Neustarts',
>>>>>   'reboot sure' => 'Sind Sie sicher, dass Sie neustarten
>>>>> wollen?',
>>>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
>>>>> index 60dca5be4..004c64b6a 100644
>>>>> --- a/langs/en/cgi-bin/en.pl
>>>>> +++ b/langs/en/cgi-bin/en.pl
>>>>> @@ -2198,7 +2198,7 @@
>>>>>   'real address' => 'Real Address',
>>>>>   'reboot' => 'Reboot',
>>>>>   'reboot ask' => 'Reboot?',
>>>>> -'reboot fsck' => 'Reboot & check filesystem',
>>>>> +'reboot fsck' => 'Reboot & run &lsquo;fsck&rsquo;',
>>>>>   'reboot question' => 'Extra query for restart and shutdown',
>>>>>   'reboot schedule' => 'Schedule IPFire reboots',
>>>>>   'reboot sure' => 'Are you sure that you want to reboot?',
>>>>> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl
>>>>> index a1643557e..e46c4fa46 100644
>>>>> --- a/langs/fr/cgi-bin/fr.pl
>>>>> +++ b/langs/fr/cgi-bin/fr.pl
>>>>> @@ -2206,7 +2206,7 @@
>>>>>   'real address' => 'Adresse réelle',
>>>>>   'reboot' => 'Redémarrer',
>>>>>   'reboot ask' => 'Redémarrage ?',
>>>>> -'reboot fsck' => 'Redémarrer et vérifier le système de
>>>>> fichier',
>>>>> +'reboot fsck' => 'Redémarrer et exécuter &lsquo;fsck&rsquo;',
>>>>>   'reboot question' => 'Requête supplémentaire pour le
>>>>> redémarrage et l\'arrêt',
>>>>>   'reboot schedule' => 'Redémarrages planifiées d\'IPFire',
>>>>>   'reboot sure' => 'Etes-vous sûr de vouloir redémarrer ?',
>> 
> 
> -- 
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>