From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] Rename misleading "check filesystem" reboot option Date: Mon, 21 Nov 2022 11:16:27 +0000 Message-ID: <824C7B16-8299-4E3F-8676-67BC9424FEC9@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2536823009164251115==" List-Id: --===============2536823009164251115== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, I really like this conversation here :) > On 20 Nov 2022, at 19:49, Robin Roevens wrote: >=20 > Maybe "Check filesystem consistency" is more clear ? I think this would be the clearest option. However, I do not know why we have this button in the first place. Why would = you suspect having an inconsistent file system? And if you do, is this button= actually helping? I am not suggestion to remove it - I am just questioning why we have this and= who would use it and when. I just don=E2=80=99t know. -Michael >=20 > Or just check filesystem like it was and add a clear description on the > wiki page https://wiki.ipfire.org/configuration/system/shutdown >=20 > Robin >=20 > Tom Rymes schreef op vr 18-11-2022 om 19:15 [-0500]: >> I would argue that this won=E2=80=99t be helpful for anyone. If you are a >> person that reads =E2=80=9Ccheck filesystem=E2=80=9D and thinks that means= =E2=80=9Crepair >> filesystem=E2=80=9D, then you=E2=80=99re a person that=E2=80=99ll read =E2= =80=9Crun fsck=E2=80=9D and think >> it means =E2=80=9Crepair filesystem using fsck.=E2=80=9D >>=20 >> My suggestion would be to add another menu option that actually does >> repair things, or to change the name from =E2=80=9Ccheck filesystem=E2=80= =9D to >> =E2=80=9Ccheck filesystem (no repairs made)=E2=80=9D or something like tha= t. >>=20 >> Tom >>=20 >>> On Nov 18, 2022, at 5:44 PM, Leo-Andres Hofmann >>> wrote: >>>=20 >>> =EF=BB=BFYes, this is totally cosmetic. In the past, I have noticed a few >>> forum posts where people assumed this button would automatically >>> fix file permissions or even configuration issues. I think the new >>> label is clearer and leaves no room for false expectations. >>>=20 >>>> Am 18.11.2022 um 13:07 schrieb Bernhard Bitsch: >>>> I think this are cosmetics. >>>> The new text adds no new information. 'check filesystem' is a >>>> synonym to 'run fsck' in a Linux system, IMHO. >>>> But if it helps some users, we can change this button text. >>>>=20 >>>> Reviewed-by: Bernhard Bitsch >>>>=20 >>>>> Am 18.11.2022 um 11:49 schrieb Leo-Andres Hofmann: >>>>> Some users assume that "check filesystem" does more than >>>>> just trigger a simple "fsck" run. This patch changes the >>>>> button label to avoid confusion. >>>>>=20 >>>>> Signed-off-by: Leo-Andres Hofmann >>>>> --- >>>>> langs/de/cgi-bin/de.pl | 2 +- >>>>> langs/en/cgi-bin/en.pl | 2 +- >>>>> langs/fr/cgi-bin/fr.pl | 2 +- >>>>> 3 files changed, 3 insertions(+), 3 deletions(-) >>>>>=20 >>>>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl >>>>> index db7d117b0..110e4ccba 100644 >>>>> --- a/langs/de/cgi-bin/de.pl >>>>> +++ b/langs/de/cgi-bin/de.pl >>>>> @@ -2144,7 +2144,7 @@ >>>>> 'real address' =3D> 'Reale Addresse', >>>>> 'reboot' =3D> 'Neustart', >>>>> 'reboot ask' =3D> 'Neustart?', >>>>> -'reboot fsck' =3D> 'Neustart & Dateisystem-Test', >>>>> +'reboot fsck' =3D> 'Neustart & ‘fsck’ ausf=C3=BChren', >>>>> 'reboot question' =3D> 'Extra Abfrage bei neustart und >>>>> herunterfahren einschalten', >>>>> 'reboot schedule' =3D> 'Zeitsteuerung f=C3=BCr IPFire Neustarts', >>>>> 'reboot sure' =3D> 'Sind Sie sicher, dass Sie neustarten >>>>> wollen?', >>>>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl >>>>> index 60dca5be4..004c64b6a 100644 >>>>> --- a/langs/en/cgi-bin/en.pl >>>>> +++ b/langs/en/cgi-bin/en.pl >>>>> @@ -2198,7 +2198,7 @@ >>>>> 'real address' =3D> 'Real Address', >>>>> 'reboot' =3D> 'Reboot', >>>>> 'reboot ask' =3D> 'Reboot?', >>>>> -'reboot fsck' =3D> 'Reboot & check filesystem', >>>>> +'reboot fsck' =3D> 'Reboot & run ‘fsck’', >>>>> 'reboot question' =3D> 'Extra query for restart and shutdown', >>>>> 'reboot schedule' =3D> 'Schedule IPFire reboots', >>>>> 'reboot sure' =3D> 'Are you sure that you want to reboot?', >>>>> diff --git a/langs/fr/cgi-bin/fr.pl b/langs/fr/cgi-bin/fr.pl >>>>> index a1643557e..e46c4fa46 100644 >>>>> --- a/langs/fr/cgi-bin/fr.pl >>>>> +++ b/langs/fr/cgi-bin/fr.pl >>>>> @@ -2206,7 +2206,7 @@ >>>>> 'real address' =3D> 'Adresse r=C3=A9elle', >>>>> 'reboot' =3D> 'Red=C3=A9marrer', >>>>> 'reboot ask' =3D> 'Red=C3=A9marrage ?', >>>>> -'reboot fsck' =3D> 'Red=C3=A9marrer et v=C3=A9rifier le syst=C3=A8me de >>>>> fichier', >>>>> +'reboot fsck' =3D> 'Red=C3=A9marrer et ex=C3=A9cuter ‘fsck&rsquo= ;', >>>>> 'reboot question' =3D> 'Requ=C3=AAte suppl=C3=A9mentaire pour le >>>>> red=C3=A9marrage et l\'arr=C3=AAt', >>>>> 'reboot schedule' =3D> 'Red=C3=A9marrages planifi=C3=A9es d\'IPFire', >>>>> 'reboot sure' =3D> 'Etes-vous s=C3=BBr de vouloir red=C3=A9marrer ?', >>=20 >=20 > --=20 > Dit bericht is gescanned op virussen en andere gevaarlijke > inhoud door MailScanner en lijkt schoon te zijn. >=20 --===============2536823009164251115==--